Skip to content

Conversation

@svengeance
Copy link
Contributor

This addresses a use-case I missed in the previous feature. Ironically enough I was motivated to contribute here specifically to have Azure CI builds use GitVersion to update my web project, and I missed it. Meh.

Description

Allows project file updating for Web SDK Projects

Related Issue

Fixes #2290

Motivation and Context

I'd like to update my ASP.NET Core projects.

How Has This Been Tested?

Added a test to ensure the Microsoft.NET.Sdk.Web was an allowed SDK

Screenshots (if appropriate):

None. But you may have a picture of another one of my cats.
image

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@asbjornu asbjornu merged commit 12a2baa into GitTools:master May 27, 2020
@asbjornu
Copy link
Member

Thanks for the lovely cat picture! And also for your code contributions, but mostly for the picture of your cat. 😸 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Can not update project file info with Web SDK

2 participants