Skip to content

Ensure targets run early enough for Source Link #2298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
asbjornu merged 2 commits into from
May 30, 2020
Merged

Ensure targets run early enough for Source Link #2298

asbjornu merged 2 commits into from
May 30, 2020

Conversation

@bording
Copy link
Contributor

@bording bording commented May 29, 2020

This adds BeforeCompile to the BeforeTargets attributes of the two targets that generate source files.

Fixes #2297

asbjornu
asbjornu approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@asbjornu asbjornu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asbjornu asbjornu added this to the 5.3.x milestone May 30, 2020
@asbjornu asbjornu merged commit c35e84c into GitTools:master May 30, 2020
@asbjornu
Copy link
Member

asbjornu commented May 30, 2020

Thanks for your contribution, @bording! 🙏

@bording bording deleted the before-compile branch May 30, 2020 01:31
@arturcic arturcic removed this from the 5.3.x milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asbjornu asbjornu asbjornu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Generated source files can't be embedded by Source Link

3 participants

@bording @asbjornu @arturcic