Commits on Feb 24, 2021

1. Improve initialization of Language property …

   During regular builds MSBuild initializes `Language` to the
   language of the currently building project, e.g. C#. However, when
   running some targets like `pack` this doesn't happen. Therefore
   GitVersion has to add a default value for `Language`. Unfortunately
   `Language` is also an environment variable that GNU gettext uses,
   so the `pack` target will fail on most Linux systems where that
   environment variable is set.
   
   This change implements a fix by additionally checking
   `DefaultLanguageSourceExtension` which gets set by MSBuild at the
   same time as `Language`. If that isn't set we can be pretty sure
   that `Language` didn't get set automatically by MSBuild and can set
   a default value.
   
   This will cause existing builds to break IF they rely on being able
   to explicitly set `Language` to a value different from C#. However,
   I don't think this is a scenario that happens very often, and it can
   be easily worked around by setting the `DefaultLanguageSourceExtension`
   property to a non-empty value.
   
   This fixes #2591.

   

   ermshiperete committed Feb 24, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for 9e178c3
   • Browse repository at this point

   Copy the full SHA

   9e178c3 View commit details

   Browse the repository at this point in the history