Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version number in hotfix branch should not be ignored #2696

Closed
wants to merge 3 commits into from
Closed

Version number in hotfix branch should not be ignored #2696

wants to merge 3 commits into from

Conversation

ruhullahshah
Copy link
Contributor

For background, please see bug #2693

@ruhullahshah
Problem:
2fce58c 
The version number in the hotfix branch is not considered for version calculation
and in certain situations, such as the one illustrated by the unit test, can lead
to a wrong version number.
@ruhullahshah ruhullahshah mentioned this pull request May 18, 2021
Closed
@asbjornu
Copy link
Member

Great. Let's just be sure that this does not revert #1541.

@stale
Copy link

stale bot commented Mar 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. After 30 days from now, it will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 2, 2022
@arturcic arturcic force-pushed the main branch 4 times, most recently from 9801764 to b7a7608 Compare March 4, 2023 13:33
@arturcic arturcic mentioned this pull request Mar 19, 2023
Closed
7 tasks
@arturcic
Copy link
Member

Closed in favor of #3445

@arturcic arturcic closed this Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
failing test case
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ruhullahshah @asbjornu @arturcic