-
Notifications
You must be signed in to change notification settings - Fork 662
UpdateAssemblyInfo: create local tmp file in \obj. #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Now UpdateAssemblyInfo task creates temp assembly info file within $(ProjectDir)\obj\$(ConfigurationName). Fix #146.
|
@SimonCropp you are more familiar with the task side of things |
|
Anyone? @nulltoken @SimonCropp @andreasohlund I don't really use the task side of things so would prefer not to review this |
|
I'd prefer not to use the task as well, but this task can update AppVeyor build number and do not touch AssemblyInfo.cs files without restoring previous state. |
|
Looks good to me, @SimonCropp can you do a once over before we pull? |
|
looks good |
UpdateAssemblyInfo: create local tmp file in \obj.
|
Update NuGet package please. |
Hello, Although this pull request has been accepted, it is part of a larger milestone, namely 2.0.0. As a result, a new nuget package will not be created until everything for 2.0.0 is ready. I don't think this is far off though, so please be patient. Gary |
|
You can also grab the latest artifacts from the buildserver if you can't Side note: The version number looks hosed? cc @JakeGinnivan On Tue, Dec 9, 2014 at 8:12 AM, Gary Ewan Park notifications@github.com
|
Not good. Looks like this started happening on the 4th December. :( |
|
Seems to be this commit: On Tue, Dec 9, 2014 at 8:43 AM, Gary Ewan Park notifications@github.com
|
|
Fixed this in my latest PR, we were parsing '1' as SemanticVersion=1.0.0 If we merge my PR then we should be fine to release 2.0.0. |
Now UpdateAssemblyInfo task creates temp assembly info file within
$(ProjectDir)\obj$ (ConfigurationName).
Fix #146.
To include generated temp assembly info file to a nuget symbols package you should write in nuspec a line like this one: