Skip to content

Conversation

@lessneek
Copy link

Now UpdateAssemblyInfo task creates temp assembly info file within
$(ProjectDir)\obj$(ConfigurationName).

Fix #146.

To include generated temp assembly info file to a nuget symbols package you should write in nuspec a line like this one:

<file src="BuildTest\**\*.cs" target="src\BuildTest\" />

Now UpdateAssemblyInfo task creates temp assembly info file within
$(ProjectDir)\obj\$(ConfigurationName).

Fix #146.
@JakeGinnivan
Copy link
Contributor

@SimonCropp you are more familiar with the task side of things

@JakeGinnivan
Copy link
Contributor

Anyone? @nulltoken @SimonCropp @andreasohlund

I don't really use the task side of things so would prefer not to review this

@lessneek
Copy link
Author

lessneek commented Dec 4, 2014

I'd prefer not to use the task as well, but this task can update AppVeyor build number and do not touch AssemblyInfo.cs files without restoring previous state.

@andreasohlund
Copy link
Contributor

Looks good to me, @SimonCropp can you do a once over before we pull?

@SimonCropp
Copy link
Contributor

looks good

andreasohlund added a commit that referenced this pull request Dec 5, 2014
UpdateAssemblyInfo: create local tmp file in \obj.
@andreasohlund andreasohlund merged commit 2c902c3 into GitTools:master Dec 5, 2014
@lessneek
Copy link
Author

lessneek commented Dec 8, 2014

Update NuGet package please.

@lessneek lessneek deleted the feature/fix146 branch December 8, 2014 22:36
@gep13 gep13 added this to the 2.0.0 milestone Dec 9, 2014
@gep13
Copy link
Member

gep13 commented Dec 9, 2014

Update NuGet package please.

Hello,

Although this pull request has been accepted, it is part of a larger milestone, namely 2.0.0. As a result, a new nuget package will not be created until everything for 2.0.0 is ready. I don't think this is far off though, so please be patient.

Gary

@andreasohlund
Copy link
Contributor

You can also grab the latest artifacts from the buildserver if you can't
wait:

http://builds.particular.net/viewLog.html?buildId=64876&tab=buildResultsDiv&buildTypeId=GitFlowVersion_1Buil

Side note: The version number looks hosed? cc @JakeGinnivan

On Tue, Dec 9, 2014 at 8:12 AM, Gary Ewan Park notifications@github.com
wrote:

Update NuGet package please.

Hello,

Although this pull request has been accepted, it is part of a larger
milestone, namely 2.0.0. As a result, a new nuget package will not be
created until everything for 2.0.0 is ready. I don't think this is far off
though, so please be patient.

Gary


Reply to this email directly or view it on GitHub
#316 (comment)
.

@gep13
Copy link
Member

gep13 commented Dec 9, 2014

Side note: The version number looks hosed? cc @JakeGinnivan

Not good. Looks like this started happening on the 4th December. :(

@andreasohlund
Copy link
Contributor

Seems to be this commit:
12359cc

On Tue, Dec 9, 2014 at 8:43 AM, Gary Ewan Park notifications@github.com
wrote:

Side note: The version number looks hosed? cc @JakeGinnivan
https://github.com/jakeginnivan

Not good. Looks like this started happening on the 4th December. :(


Reply to this email directly or view it on GitHub
#316 (comment)
.

@JakeGinnivan
Copy link
Contributor

Fixed this in my latest PR, we were parsing '1' as SemanticVersion=1.0.0

If we merge my PR then we should be fine to release 2.0.0.

@SimonCropp SimonCropp removed this from the 2.0.0 milestone Dec 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto generated AssemblyFile location causes issues with symbols

5 participants