Fixes #380 - "Merge tag '1.1.0' into support/1.0" is not recognized as merge commit #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannesegger
changed the title
Contributor
|
I really need to merge the 3.0.0 branch into master, but would you be able to do this against the release/3.0.0 branch? We wanted to keep it separate to allow us to patch 2.x until we release 3.0. Also have a look at the comment I posted in #380. I am happy to just also apply this change to 3.0 |
Contributor
|
Also, I just merged #377 which changes the implementation again |
Contributor
|
Closing as we are not adding anything to 2.x anymore. Will get the 3.0.0 branch merged soon, sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.