Mark dependencies as private assets for GitVersion.MsBuild #3921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chnage that all references of the msbuild package are marked as private
assets, so they don't get added as dependency to the nuget package.
The dependecies field of the nuspec before the change:
```xml
<dependencies>
<group targetFramework="net6.0">
<dependency id="System.Text.Json" version="8.0.1" exclude="Build,Analyzers" />
</group>
<group targetFramework="net7.0">
<dependency id="System.Text.Json" version="8.0.1" exclude="Build,Analyzers" />
</group>
<group targetFramework="net8.0">
<dependency id="System.Text.Json" version="8.0.1" exclude="Build,Analyzers" />
</group>
</dependencies>
```
and afer the change the dependencies of the nuspec look like this:
```xml
<dependencies>
<group targetFramework="net6.0" />
<group targetFramework="net7.0" />
<group targetFramework="net8.0" />
</dependencies>
```
|
@Louis9902 it seems the PR passes all the tests we have, including testing the actual nuget package. I will check the nuget package the CI generated locally and see if it works as expected. Thanks btw for the changes, it makes the nuspec much cleaner. |
|
It works. Looks great |
arturcic
approved these changes
Feb 20, 2024
arturcic
changed the title
|
Thank you @Louis9902 for your contribution! |
|
🎉 This issue has been resolved in version 6.0.0-beta.6 🎉 Your GitReleaseManager bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change that all references of the msbuild package are marked as private assets, so they don't get added as dependency to the nuget package.
The dependecies field of the nuspec before the change:
and afer the change the dependencies of the nuspec look like this:
Related Issue
No, so far, happy to create one if the pr is not enough
Motivation and Context
The dependencies cause extra dll's to be published, for build only dependencies (
PrivateAssets="All"). This problem seems to be cause by the change to the ceontral package management, whereSystem.Text.Jsonwas promoted to be included in theDirectory.Build.propsHow Has This Been Tested?
Build locally and checked the generated nuspec file in the outpur directory.
Screenshots (if appropriate):
Checklist: