(build) - fix dockerhub readme publish #4281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move the publish event to the release stage
arturcic
force-pushed
the
feature/dockerhub-readme-publish
branch
from
556cb7b to
d4a010e
Compare
|
Thank you @arturcic for your contribution! |
|
🎉 This issue has been resolved in version 6.0.5 🎉 Your GitReleaseManager bot 📦🚀 |
arturcic
added a commit
to arturcic/GitVersion
that referenced
this pull request
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the DockerHub README publishing process, mainly focusing on workflow adjustments and code refactoring for asynchronous operations.
Workflow adjustments:
.github/workflows/_docker.yml: Removed theDockerHub Publish Readmejob from the Docker workflow..github/workflows/ci.yml: Added theDockerHub Publish Readmejob to the CI workflow, triggered by therepository_dispatchevent.Code refactoring:
build/docker/Tasks/DockerHubReadmePublish.cs: Changed theDockerHubReadmePublishInternalclass to inherit fromAsyncFrostingTaskinstead ofFrostingTaskand updated theRunmethod toRunAsyncfor asynchronous execution. [1] [2]build/docker/Tasks/DockerHubReadmePublish.cs: Added logging statements to provide more detailed information during the execution of theRunAsyncmethod.