-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
branch regex is matched against {EscapedBranchName} not {BranchName} #4383
branch regex is matched against {EscapedBranchName} not {BranchName} #4383
Conversation
Nice one 😄 |
After FluentAssertion moved from Apache 2.0 to source-available (paid for commercial use), I thought about it. From now on I will be transparent about how much I get for my work and who sponsored me. Since no one does this, I can charge for the hours I spent if GitVersion also changes the license model in future. The problem of underfunding of open source projects like GitVersion still exists. I would like to implement and stabilize more functionalities. But no one except you and me seems to be active here at all (meaning of implementing features and bug fixes). This makes me very sad. |
@HHobeck can you update https://github.com/GitTools/GitVersion/blob/4f66abd9c3f1dad659b7774039bde3d332e0765e/docs/input/docs/reference/mdsource/configuration.source.md instead of the GitVersion/.github/workflows/mkdocs.yml Lines 31 to 32 in 4f66abd
/docs/input folder.
Please also rebase the branch onto |
@HHobeck can you please rebase instead of merge? |
5004715
to
dc78cbd
Compare
Please have a look |
4dd4329
to
85151a1
Compare
@arturcic please merge to main. Thank you! |
@HHobeck now that you updated the schema as well? dotnet build build/CI.sln --configuration=Release
dotnet run/build.dll --target=BuildPrepare
dotnet run/docs.dll --target=GenerateSchemas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you @HHobeck for your contribution! |
Description
Time invested:
3,50h
Sponsored by:
Nobody
Checklist: