Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch regex is matched against {EscapedBranchName} not {BranchName} #4383

Merged

Conversation

HHobeck
Copy link
Contributor

@HHobeck HHobeck commented Jan 18, 2025

Description

Time invested:

3,50h

Sponsored by:

Nobody

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sorry, something went wrong.

@arturcic
Copy link
Member

Sponsored by:
Nobody

Nice one 😄

@HHobeck
Copy link
Contributor Author

HHobeck commented Jan 18, 2025

Nice one 😄

After FluentAssertion moved from Apache 2.0 to source-available (paid for commercial use), I thought about it. From now on I will be transparent about how much I get for my work and who sponsored me. Since no one does this, I can charge for the hours I spent if GitVersion also changes the license model in future.

The problem of underfunding of open source projects like GitVersion still exists. I would like to implement and stabilize more functionalities. But no one except you and me seems to be active here at all (meaning of implementing features and bug fixes). This makes me very sad.

@HHobeck HHobeck requested a review from arturcic January 19, 2025 07:55
@arturcic
Copy link
Member

@HHobeck can you update https://github.com/GitTools/GitVersion/blob/4f66abd9c3f1dad659b7774039bde3d332e0765e/docs/input/docs/reference/mdsource/configuration.source.md instead of the configuration.md.
Then you can run

dotnet tool install --global MarkdownSnippets.Tool
mdsnippets --write-header false
from the /docs/input folder.

Please also rebase the branch onto main

@arturcic
Copy link
Member

@HHobeck can you please rebase instead of merge?

@HHobeck HHobeck force-pushed the hotfix/4154-wrong-branch-regex-resolution branch 2 times, most recently from 5004715 to dc78cbd Compare January 28, 2025 09:26
@HHobeck
Copy link
Contributor Author

HHobeck commented Jan 28, 2025

Please have a look

@HHobeck HHobeck force-pushed the hotfix/4154-wrong-branch-regex-resolution branch from 4dd4329 to 85151a1 Compare February 1, 2025 10:35
@HHobeck
Copy link
Contributor Author

HHobeck commented Feb 1, 2025

@arturcic please merge to main. Thank you!

@arturcic
Copy link
Member

arturcic commented Feb 1, 2025

@HHobeck now that you updated the schema as well?

dotnet build build/CI.sln --configuration=Release
dotnet run/build.dll --target=BuildPrepare
dotnet run/docs.dll --target=GenerateSchemas

@arturcic arturcic added this to the 6.1.x milestone Feb 1, 2025
@arturcic arturcic enabled auto-merge (rebase) February 1, 2025 12:38
Copy link
Member

@arturcic arturcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arturcic arturcic merged commit 0e73ee4 into GitTools:main Feb 1, 2025
98 checks passed
@arturcic arturcic deleted the hotfix/4154-wrong-branch-regex-resolution branch February 1, 2025 12:38
Copy link
Contributor

mergify bot commented Feb 1, 2025

Thank you @HHobeck for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants