Improve the language discovery heuristics of AssemblyInfoBuilder #915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asbjornu
force-pushed
the
feature/assembly-info-builder-language-discovery
branch
from
c447240 to
ef3bd92
Compare
Member
|
@asbjornu LGTM. If you rebase the branch I can merge this. |
Improve how the AssemblyInfoBuilder discovers what language is being compiled by not looking for an `AssemblyInfo.*` file, but instead finding the first *.vb og *.cs file and deducing the langauge from there. Also adds a few more guards and tests for AssemblyInfoBuilder to make it more robust and easier to understand if it breaks.
asbjornu
force-pushed
the
feature/assembly-info-builder-language-discovery
branch
from
ef3bd92 to
45590b5
Compare
Member
Author
|
@pascalberger Thanks. Rebased and all green. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves how the
AssemblyInfoBuilderdiscovers what language is being compiled by not looking for anAssemblyInfo.*file, but instead finding the first*.vbor*.csfile and deducing the langauge from there.Also adds a few more guards and tests for
AssemblyInfoBuilderto make it more robust and easier to understand if it breaks.Fixes #885.