Skip to content

Don't swallow exceptions from LibGit2Sharp #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asbjornu merged 2 commits into from
Jun 29, 2016
Merged

Don't swallow exceptions from LibGit2Sharp #917

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5df71a1
Fixed typo: Software and its features are usually 'deprecated', not '…
asbjornu Jun 29, 2016
c4f0e76
Don't swallow unexpected exceptions form LibGit2Sharp; they might be …
asbjornu Jun 29, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/GitVersionCore/GitPreparer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ static void CloneRepository(string repositoryUrl, string gitDirectory, Authentic
throw new Exception("Not found: The repository was not found");
}

throw new Exception("There was an unknown problem with the Git repository you provided");
throw new Exception("There was an unknown problem with the Git repository you provided", ex);
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/GitVersionCore/GitVersionFinder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public SemanticVersion FindVersion(GitVersionContext context)
var filePath = Path.Combine(context.Repository.GetRepositoryDirectory(), "NextVersion.txt");
if (File.Exists(filePath))
{
throw new WarningException("NextVersion.txt has been depreciated. See http://gitversion.readthedocs.org/en/latest/configuration/ for replacement");
throw new WarningException("NextVersion.txt has been deprecated. See http://gitversion.readthedocs.org/en/latest/configuration/ for replacement");
}

return new NextVersionCalculator().FindVersion(context);
Expand Down