Remove borders on Caption wrapper #2742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GitBook Preview |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
zenoachtig
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Caption component wraps elements that can potentially have a caption (these are Files, Images, Drawing and Embed. Whether you add a caption or not doesnt matter, they all get the border that is set on the Caption wrapper.
It was suggested that this is not ideal for images that are diagrams, and I can imagine the same holds for Drawing blocks. This PR removes the border, the Files block keeps its border which we want.
Raised here: https://github.com/orgs/GitbookIO/discussions/830 (thanks Janice!)
Before:
After: