Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the proxy request identifier for storing the VA cookie in proxy sites #3091

Merged
merged 24 commits into from
Apr 9, 2025

Conversation

taranvohra
Copy link
Member

@taranvohra taranvohra commented Apr 4, 2025

Since proxy requests are of the form https://proxy.gitbook.site/sites/<siteId>/path we ensure the siteBasePath here is consistent during storing and retrieving the cookie

Copy link
Contributor

github-actions bot commented Apr 4, 2025

Copy link

argos-ci bot commented Apr 4, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v1 (Inspect) ✅ No changes detected - Apr 9, 2025, 6:49 AM
customers-v2 (Inspect) ✅ No changes detected - Apr 9, 2025, 6:50 AM
default (Inspect) ✅ No changes detected - Apr 9, 2025, 6:51 AM
v2-vercel (Inspect) 👍 Changes approved 8 added Apr 9, 2025, 6:53 AM

Copy link

changeset-bot bot commented Apr 5, 2025

⚠️ No Changeset found

Latest commit: 599ce1c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@taranvohra taranvohra merged commit f23023d into main Apr 9, 2025
18 checks passed
@taranvohra taranvohra deleted the taran/fix-va-cookie-proxy-sites branch April 9, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants