Handle nested deprecated properties in generateSchemaExample #3267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 45af44c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
Adds support for excluding deprecated properties at both the schema and array-item levels from generated examples.
- Extend deprecation check to array items in
generateSchemaExample - Add tests covering schema-level and nested (array-item) deprecation
- Include a changeset to document the patch
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/react-openapi/src/generateSchemaExample.ts | Update deprecation condition to also filter out deprecated items |
| packages/react-openapi/src/generateSchemaExample.test.ts | Add tests for schema deprecation and nested (array-item) deprecation |
| .changeset/thick-chefs-repeat.md | Document the patch release in changeset |
Comments suppressed due to low confidence (1)
packages/react-openapi/src/generateSchemaExample.test.ts:1030
- [nitpick] The test description should use a consistent verb form (e.g.,
handles nested deprecated properties) to match the other test and improve naming consistency.
it('handle nested deprecated properties', () => {
nolannbiron
force-pushed
the
nolann/rnd-7152-openapi-null-errors-since-latest-release
branch
from
c514c8e to
45af44c
Compare
|
Summary of the deployments: Version 1
Version 2
Test content |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
gregberge
approved these changes
May 26, 2025
nolannbiron
deleted the
nolann/rnd-7152-openapi-null-errors-since-latest-release
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.