-
-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gix-index
towards 1.0
#293
Labels
C-tracking-issue
An issue to track to track the progress of multiple PRs or issues
Comments
Byron
added a commit
that referenced
this issue
Jan 8, 2022
Byron
added a commit
that referenced
this issue
Jan 8, 2022
Note that in-code we must make sufficiently clear where a particular fixture is coming from, or we name it after the test and file right away.
Byron
added a commit
that referenced
this issue
Jan 8, 2022
It deals with comparing items from the work tree and the index, and is generally what makes use of exclude specificiations.
Byron
added a commit
that referenced
this issue
Jan 8, 2022
It should be easy enough to learn from git tests to generate whichever kind of index we need.
Byron
added a commit
that referenced
this issue
Jan 9, 2022
Byron
added a commit
that referenced
this issue
Jan 9, 2022
Byron
added a commit
that referenced
this issue
Jan 9, 2022
Byron
added a commit
that referenced
this issue
Jan 9, 2022
Byron
added a commit
that referenced
this issue
Jan 9, 2022
This is now sufficiently well implemented in the standard library.
Byron
added a commit
that referenced
this issue
Jan 9, 2022
It's sufficiently well supported using the standard library now.
Byron
added a commit
that referenced
this issue
Jan 9, 2022
Byron
added a commit
that referenced
this issue
Jan 9, 2022
Byron
added a commit
that referenced
this issue
Jan 9, 2022
Byron
added a commit
that referenced
this issue
Jan 9, 2022
Byron
added a commit
that referenced
this issue
Jan 10, 2022
Byron
added a commit
that referenced
this issue
Jan 10, 2022
Byron
added a commit
that referenced
this issue
Jan 10, 2022
For now the data structure is just 'as-written' and we see what needs to change there as we have to maintain it.
Byron
added a commit
that referenced
this issue
Jan 10, 2022
Byron
added a commit
that referenced
this issue
Jan 10, 2022
Byron
added a commit
that referenced
this issue
Jan 10, 2022
Byron
added a commit
that referenced
this issue
Jan 25, 2022
Byron
added a commit
that referenced
this issue
Jan 27, 2022
Byron
added a commit
that referenced
this issue
Jan 27, 2022
This also fixes an issue with the node-id seemingly being optional, even though it is not.
Byron
added a commit
that referenced
this issue
Jan 27, 2022
Byron
added a commit
that referenced
this issue
Jan 27, 2022
…until we know what to do with their data, which is when we can assert more.
Byron
added a commit
that referenced
this issue
Jan 27, 2022
As it was missing the final length test as seen here: https://github.com/git/git/blob/main/read-cache.c#L531:L531
Byron
added a commit
that referenced
this issue
Jan 27, 2022
Byron
added a commit
that referenced
this issue
Jan 27, 2022
Byron
added a commit
that referenced
this issue
Jan 27, 2022
Byron
added a commit
that referenced
this issue
Jan 27, 2022
Either it's the way these are loaded, maybe they are missing a step, or it's the way we think they are sorted, as they definitely aren't sorted the way we think they are.
Byron
added a commit
that referenced
this issue
Jan 28, 2022
This is based on the way git is reading back the TREE extension, which subtly inserts the read items into their position based on alphabetical order (not the index sort order for entries, or tree entries). See https://github.com/git/git/blob/main/cache-tree.c#L604:L604
Byron
added a commit
that referenced
this issue
Jan 28, 2022
Byron
added a commit
that referenced
this issue
Jan 28, 2022
Will need more work to deal with multi-workspace repositories
Byron
added a commit
that referenced
this issue
Jan 28, 2022
…nsion() (#293) One cannot use `Option` as intermediary as this breaks closure inference entirely. There should be an issue for this, let's reproduce it and see what to watch.
Byron
added a commit
that referenced
this issue
Jan 31, 2022
Byron
added a commit
that referenced
this issue
Feb 1, 2022
It's mainly for completeness to provide people with with a `FullNameRef` of HEAD.
Byron
added a commit
that referenced
this issue
Feb 2, 2022
Byron
added a commit
that referenced
this issue
Feb 22, 2022
The current implementation could possibly be improved by implementing sorting along with duplication checks, but right now it seems fast enough.
Byron
added a commit
that referenced
this issue
Feb 22, 2022
Byron
added a commit
that referenced
this issue
Feb 23, 2022
3 tasks
44 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Only interpret and make accessible all values and figure out how to bridge different formats in a single implementation ideally.
Reading
link
andsdir
std::thread::scope()
instead of statically scoped threads, which should make it easier (needs Rust 1.63 MVP)Instantiation
git
can actually traverse multiple trees at the same time, maybe taking advantage of them being sorted. It seems to unpack the same entry on each level for comparison..git
(on macos with case-insensitivity, should be a configuration flag). Handles backslashes in paths, too, on windows, rejecting them.Writing
Definitely round-trip tests with what we are reading.
.git
named entriesTREE
extension can be used to accelerate the tree generation.CE_REMOVED
flags](https://github.com/git/git/blob/master/read-cache.c#L2894:L2894Plumbing
Research
notify
based implementation, avoiding thewatchman
tool.The text was updated successfully, but these errors were encountered: