-
-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gix fetch sometimes gets stuck during negociation #882
Comments
Thanks for giving it a try and for providing a reproduction :)! I am indeed able to reproduce the issue and know what the problem is. In short, despite having faithfully implemented negotiation, I skimped on one details of V1 negotiation which will deadlock unless one adds what considerable complication to the implementation. Even though I was able to satisfy my own tests, it's not enough to satisfy this example. However, I am sure I will be back with a fix shortly and hope that one will work better in the real world :D. |
… specialty (#882). Seeing READY means a pack will follow, which is exactly the kind of knowledge we want. Thus we now either listen to the client OR to what the server says.
PR #884 has the fix, and I will release it shortly, but while investigating I noticed something else:
Fortunately, no matter what, the pack that |
… specialty (#882). Seeing READY means a pack will follow, which is exactly the kind of knowledge we want. Thus we now either listen to the client OR to what the server says. Note that this remedy relies on `multi-ack-detailed`, which some very old servers might not support. For those we would be out-of-luck, but that seems acceptable.
Could you build locally and retry, now that the fix was released via
|
This fix works for me, thank you! |
Duplicates
Current behavior 😯
Fetching the attached repo with gix (gitoxide 0.26.0) doesn't converge, gets stuck on
negotiate (round 3) 1 steps [ ===
…Followup to #861 and #812.
fedora-kickstarts.git.tar.gz
Expected behavior 🤔
Fetch the repo
Steps to reproduce 🕹
untar, cd
gix fetch
Running git fetch once will prevent the issue with gix fetch, don't run git before reproducing
The text was updated successfully, but these errors were encountered: