Update winnow to 0.6 #1290
Merged
Update winnow to 0.6 #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epage
force-pushed
the
winnow
branch
4 times, most recently
from
9d02954 to
e175b20
Compare
epage
commented
Feb 13, 2024
| @@ -162,7 +162,7 @@ mod tests { | |||
| .map_err(to_bstr_err) | |||
| .expect_err("parse fails as > is missing") | |||
| .to_string(), | |||
| "in slice at ' 12345 -1215'\n 0: expected `<email>` at ' 12345 -1215'\n 1: expected `<name> <<email>>` at ' 12345 -1215'\n 2: expected `<name> <<email>> <timestamp> <+|-><HHMM>` at ' 12345 -1215'\n" | |||
| "in slice at ' 12345 -1215'\n 0: expected `<email>` at ' 12345 -1215'\n 1: expected `<name> <<email>>` at 'hello < 12345 -1215'\n 2: expected `<name> <<email>> <timestamp> <+|-><HHMM>` at 'hello < 12345 -1215'\n" | |||
There was a problem hiding this comment.
0.6 included a change that allows TreeError to behave closer to how nom behaved with errors in capturing the start location for each stage things are processed rather than always attaching it to only the original error location
Byron
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required using
winnow::stream::BStrin test errors becauseTreeErrornow needsimpl Stream for I.