Use Dependabot version updates but just for GitHub Actions #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 7, 2024
This comment was marked as resolved.
This comment was marked as resolved.
A number of reusable actions, such as actions/checkout, are in old major versions, including versions that use old deprecated versions of Node.js, such as Node 16 (rather than the current Node 20). Dependabot version updates were disabled for Rust crates in GitoxideLabs#143 and GitoxideLabs#144, with other means used to keep things up to date. This does not reverse that even partially, as it enables version updates only for GitHub Actions (which it has not been used on before). Because most actions are specified with major version tags that get reset to the latest stable minor/patch version under that major version, the actual frequency of updates should not be anywhere near daily. Nonetheless, it may make sense to further refine this configuration, such as to check for updates less often as well as to group multiple updates into a single PR when doing so.
EliahKagan
force-pushed
the
gha-version-updates
branch
from
cd31a8d to
cf7bf17
Compare
Byron
approved these changes
May 7, 2024
EliahKagan
added a commit
to EliahKagan/gitoxide
that referenced
this pull request
Nov 11, 2024
In the past (GitoxideLabs#143), Dependabot version updates had been used to keep `cargo` dependencies up to date. This was removed in favor of doing manual updates based on automatic reports from `cargo deny` and the old `dependabot.yml` was kept but renamed to disable it and point people to GitoxideLabs#144 to learn about the change. Since then, Dependabot security updates, which are distinct from Dependabot version updates, were enabled (see GitoxideLabs#1254), and later, Dependabot version updates were reintroduced for GitHub Actions only (GitoxideLabs#1357). At that point, there were two Dependabot-related YAML files: the old disabled one, and the new one for GHA. This removes the old one, explaining the situation in a comment in the new one, including a link to GitoxideLabs#144. While doing so, this also adjusts the YAML code style there, to bring it in line with the style of most other YAML files in the repository.
EliahKagan
added a commit
to EliahKagan/gitoxide
that referenced
this pull request
Nov 11, 2024
In the past (GitoxideLabs#143), Dependabot version updates had been used to keep `cargo` dependencies up to date. This was removed in favor of doing manual updates based on automatic reports from `cargo deny` and the old `dependabot.yml` was kept but renamed to disable it and point people to GitoxideLabs#144 to learn about the change. Since then, Dependabot security updates, which are distinct from Dependabot version updates, were enabled (see GitoxideLabs#1254), and later, Dependabot version updates were reintroduced for GitHub Actions only (GitoxideLabs#1357). At that point, there were two Dependabot-related YAML files: the old disabled one, and the new one for GHA. This removes the old one, explaining the situation in a comment in the new one, including a link to GitoxideLabs#144. While doing so, this also adjusts the YAML code style there, to bring it in line with the style of most other YAML files in the repository.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of actions, such as
actions/checkout, are in old major versions, including versions that use old deprecated versions of Node.js, such as Node 16 (rather than the current Node 20). In addition, using old versions, especially when they are no longer fully supported, sometimes leads to breakages, which seems to be what has happened in #1355.Dependabot version updates were disabled for Rust crates in #143 and #144, with other means used to keep things up to date. This does not reverse that even partially, as it enables version updates only for GitHub Actions (which it has not been used on before).
The first commit here defined non-grouped version updates with a daily cadence. If that is wanted, then the second commit can be reverted or dropped. Because most actions are specified with major version tags that get reset to the latest stable minor/patch version under that major version, the actual frequency of updates should not be anywhere near daily, even with that configuration.
Nonetheless, given the history of not wanting to be bothered too often by Dependabot, combined with the very slow rate at which problem seem to be occurring in this repository relating to old actions versions, the second commit here changes it to check for updates weekly, as well as to group multiple updates into a single PR when doing so.
An even more important reason to prefer this may be that it allows multiple new action versions to be tested together without having to rebase and rerun CI checks.
Dependabot configurations can't actually be tested in a PR, and GitHub does not even always validate that they are syntactically correct and match the appropriate schema, but I made a similar change in one of my own repositories first to verify that it works.
(That repository relates to the topic of old actions versions in that it is a demonstration and test repository for https://github.com/orgs/community/discussions/113020, which I think might be fixed now but I haven't yet checked. That is altogether peripheral to the matter of old action versions here in the gitoxide repository, unless it turns out some actions have to be kept on versions meant for Node 16 for some reason, which probably will not happen. The significance of that repository to this PR is more just that it is a repository with a recently added Dependabot configuration similar to what I am proposing here.)
I've rebased this onto main after #1356 was merged, so this feature branch should no longer suffer from #1355. So all CI checks should be able to pass on this PR now.