Bump the github-actions group with 6 updates #1362
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
|
@dependabot rebase main |
Bumps the github-actions group with 6 updates: | Package | From | To | | --- | --- | --- | | [actions/checkout](https://github.com/actions/checkout) | `3` | `4` | | [extractions/setup-just](https://github.com/extractions/setup-just) | `1` | `2` | | [actions/upload-artifact](https://github.com/actions/upload-artifact) | `3` | `4` | | [dtolnay/rust-toolchain](https://github.com/dtolnay/rust-toolchain) | `1.67.0` | `1.80.0` | | [actions/download-artifact](https://github.com/actions/download-artifact) | `3` | `4` | | [actions/upload-release-asset](https://github.com/actions/upload-release-asset) | `1.0.1` | `1.0.2` | Updates `actions/checkout` from 3 to 4 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) Updates `extractions/setup-just` from 1 to 2 - [Release notes](https://github.com/extractions/setup-just/releases) - [Commits](extractions/setup-just@v1...v2) Updates `actions/upload-artifact` from 3 to 4 - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v3...v4) Updates `dtolnay/rust-toolchain` from 1.67.0 to 1.80.0 - [Release notes](https://github.com/dtolnay/rust-toolchain/releases) - [Commits](dtolnay/rust-toolchain@1.67.0...1.80.0) Updates `actions/download-artifact` from 3 to 4 - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v3...v4) Updates `actions/upload-release-asset` from 1.0.1 to 1.0.2 - [Release notes](https://github.com/actions/upload-release-asset/releases) - [Commits](actions/upload-release-asset@v1.0.1...v1.0.2) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions - dependency-name: extractions/setup-just dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions - dependency-name: dtolnay/rust-toolchain dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-actions - dependency-name: actions/download-artifact dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions - dependency-name: actions/upload-release-asset dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/github_actions/github-actions-995368d36e
branch
from
45edd48
to
a64d015
Compare
If this doesn't work, so it happens once per week now, better replace it with rustup invocations.
When `dtolnay/rust-toolchain` is a tag, it specifies a particular version of the actual Rust toolchain to use. It is also sometimes used with a branch such as `master` (to then specify the version as an option rather than in the action version) or `stable`, but branches are ineligible for Dependabot version updates and also would not ordinarily require them since they move much more often than tags. Therefore, this tells Dependabot to ignore `dtolnay/rust-toolchain` for the purpose of version updates. As commented, this is done in a way that *should* avoid causing it to be ignored for security updates. Old Rust toolchains may have known vulnerabilities but still be safe to use on CI based on a consideration of the risks (for triggers such as `push` and `pull_request` that run with the same privileges of the user who can cause the triggering event to occur), and I believe the action itself does not get advisories for those versions. But it is possible that at some point in the future a vulnerability might be discovered in the action itself and an advisory produced for it, so having Dependabot be able to show any such advisory and, if enabled, produce a security update PR for it automatically is still valuable. Ignoring `dtolnay/rust-toolchain` addresses the problem identified in GitoxideLabs#1362 (review) without requiring any decreased use of actions to install dependencies, modification of how the actions' versions or options are given, or `@dependabot` ignore commands.
When `dtolnay/rust-toolchain` is a tag, it specifies a particular version of the actual Rust toolchain to use. It is also sometimes used with a branch such as `master` (to then specify the version as an option rather than in the action version) or `stable`, but branches are ineligible for Dependabot version updates and also would not ordinarily require them since they move much more often than tags. Therefore, this tells Dependabot to ignore `dtolnay/rust-toolchain` for the purpose of version updates. As commented, this is done in a way that *should* avoid causing it to be ignored for security updates. Old Rust toolchains may have known vulnerabilities but still be safe to use on CI based on a consideration of the risks (for triggers such as `push` and `pull_request` that run with the same privileges of the user who can cause the triggering event to occur), and I believe the action itself does not get advisories for those versions. But it is possible that at some point in the future a vulnerability might be discovered in the action itself and an advisory produced for it, so having Dependabot be able to show any related alert and, if enabled, produce a security update PR for it automatically is still valuable. Ignoring `dtolnay/rust-toolchain` addresses the problem identified in GitoxideLabs#1362 (review) without requiring any decreased use of actions to install dependencies, modification of how the actions' versions or options are given, or `@dependabot` ignore commands.
There was a problem hiding this comment.
Although this looks good and could be merged immediately, I've opened #1364 to make it so Dependabot no longer attempts to update dtolnay/rust-toolchain. As detailed there, the easiest and most robust way to verify the effect of that change may involve merging that PR before this one.
Relating to the message (but not diff) of cd6d578, please note that, even if for some reason #1364 were not to be merged, it should not be necessary to use actions less extensively to install toolchains or any other dependencies, because there are two other ways to keep Dependabot from attempting to upgrade that dependency (they are listed in that PR description, among the list of things that PR, if merged, will make it unnecessary to do).
|
Thank you! I actually plan to remove this action entirely in favor of plain rustup calls, so probably won't end up merging #1364. |
Byron
force-pushed
the
dependabot/github_actions/github-actions-995368d36e
branch
2 times, most recently
from
17d0d01
to
ca58484
Compare
Using it when availble as standard tool seems preferable over using an action that potentially hides away what's truly going on (after all, it also calls `rustup` under the hood)
Byron
force-pushed
the
dependabot/github_actions/github-actions-995368d36e
branch
from
ca58484
to
c97ee27
Compare
Sounds good. I hope Dependabot is not the reason for replacing that action, since even if you don't want the changes from #1364 in the configuration, Dependabot can be told to ignore updates with Regardless of the reason, I will go ahead and close #1364 if it is still open after this PR is merged--because this PR contains c97ee27 which makes it unnecessary--unless you indicate that it should remain open. (And of course I have no objection to you closing it, if you like!) |
dependabot
bot
deleted the
dependabot/github_actions/github-actions-995368d36e
branch
It's a long-standing issue of over-abstraction and I thought it was a fruit hanging low enough to tackle now, as a form of warmup. Please also note that Windows was subtly broken, but that's fixed in 91b6549 which lives in this PR - it's my work-PR that captures feature-goals but is also often used to contain smaller fixes which may be merged back occasionally. I should probably use that less in favor of separate PRs now. |
|
Thanks for clarification regarding For the Windows breakage, at least in this instance, I'm not aware of any reason having the fix for in that PR would be a problem, at least for anything I'm working on. But I understand having separate PRs for such things does have benefits. I have an idea about that though, which might potentially lead to an alternative fix. So I've commented #1363 (comment) about that. |
Bumps the github-actions group with 6 updates:
3412341.67.01.80.0341.0.11.0.2Updates
actions/checkoutfrom 3 to 4Release notes
Sourced from actions/checkout's releases.
... (truncated)
Changelog
Sourced from actions/checkout's changelog.
... (truncated)
Commits
0ad4b8fPrep Release v4.1.4 (#1704)43045aeDisableextensions.worktreeConfigwhen disablingsparse-checkout(#1692)37b0821Bump the minor-actions-dependencies group with 2 updates (#1693)9839dc1Add dependabot config (#1688)9b4c13bBump word-wrap from 1.2.3 to 1.2.5 (#1643)1d96c77Add SSH user parameter (#1685)cd7d8d6Check git version before attempting to disablesparse-checkout(#1656)8410ad0Updateactions/checkoutversion inupdate-main-version.yml(#1650)9bb5618Prep for release of v4.1.2 (#1649)8eb1f6aBump@babel/traversefrom 7.20.5 to 7.24.0 (#1642)Updates
extractions/setup-justfrom 1 to 2Commits
dd310adThis is 2.0.0b88c09dUpgrade GitHub Actionsdcec242Upgrade dependenciesfbd91a8Use Node v205024487Build: just v1.23.0 (#15)1b96160doc: Fix invalid GHA syntax in github-token example (#12)Updates
actions/upload-artifactfrom 3 to 4Release notes
Sourced from actions/upload-artifact's releases.
Commits
6546280updating package versionc004fb4Merge branch 'main' into eggyhead/use-artifact-v2.1.690aba49updating toolkit artifact dependency to 2.1.6b06cde3Merge pull request #563 from actions/eggyhead/release-4.3.21746f4aRevert "updating to release 4.3.2"31685d0updating to release 4.3.218bf333Merge pull request #562 from actions/eggyhead/update-artifact-v215dac413bupdate package lock versionbb3b4a3updating package version3e3da83updating artifact and core dependenciesUpdates
dtolnay/rust-toolchainfrom 1.67.0 to 1.80.0Commits
2398b6dtoolchain: 1.80.0Updates
actions/download-artifactfrom 3 to 4Release notes
Sourced from actions/download-artifact's releases.
Commits
65a9edcMerge pull request #325 from bethanyj28/mainfdd1595licensedc13dba1update@actions/artifactdependency0daa75eMerge pull request #324 from actions/eggyhead/use-artifact-v2.1.69c19ed7Merge branch 'main' into eggyhead/use-artifact-v2.1.63d3ea87updating license89af5dbupdating artifact package v2.1.6b4aefffMerge pull request #323 from actions/eggyhead/update-artifact-v2158caf195package lock updated7a2ec4updating package versionUpdates
actions/upload-release-assetfrom 1.0.1 to 1.0.2Release notes
Sourced from actions/upload-release-asset's releases.
Commits
e8f9f06Merge pull request #27 from actions/IAmHughes/add-automated-versioning1418754Add versioning action to automatically slide major versions with releases7d8fb6cMerge pull request #6 from actions/IAmHughes/fix-link-to-licensec53f077Fix link to LICENSE72e8a5eMerge pull request #5 from cesperanc/documentation-updatebf2a7fbUpdate example to use the fixed versionDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions