Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

empty paths don't error in lenient mode #1371

Merged
merged 1 commit into from
May 17, 2024
Merged

Conversation

Byron
Copy link
Member

@Byron Byron commented May 17, 2024

When using gix::open_opts(path, options.strict_config(false)), empty core.excludesFile values will not cause an error anymore.

Note that in strict mode, the behaviour is unchanged so invalid configuration can rather be fixed than ignored.

Fixes #1370 .

@EliahKagan
Copy link
Member

EliahKagan commented May 17, 2024

The Windows test failure is due to nextest-rs/nextest#1493 (see also rust-lang/rustup#3825). Rerunning the test should produce the same error (though I agree with doing so, just to be sure) produces the same error. It is not specific to the code in this PR, also occurring when formerly successful checks on the main branch are rerun, and locally. I have also verified, both locally and on CI, that it is also not related to any recent changes in gix-macros.

Until a proper fix is released, it should be possible to fix it by setting RUSTUP_WINDOWS_PATH_ADD_BIN=1, as in ruffle-rs/ruffle#16342. I've verified that this works locally, but I haven't yet done it on CI. I'll open a pull request here in gitoxide with that workaround shortly, so PRs such as this one can move forward until an upstream fix is available. Alternative, if you prefer to apply the change here instead, please let me know (or close my forthcoming PR if already open).

@Byron
Copy link
Member Author

Byron commented May 17, 2024

Thanks a lot for your help here - incredible how fast you figured that out, I was still puzzled.

I'd be happy to wait until your PR is merged to fix this one.

@EliahKagan
Copy link
Member

I've opened #1372 for this, adding that environment variable where needed.

Thanks a lot for your help here - incredible how fast you figured that out, I was still puzzled.

Thanks! I should admit I didn't figure it out quite as fast as it might've seemed, though. Instead, the timing was fortuitous--I had already experienced the problem locally and was working on it for a short while before I saw this PR.

…iguration enabled. (#1370)

When using `gix::open_opts(path, options.strict_config(false))`, empty `core.excludesFile` values
will not cause an error anymore.

Note that in strict mode, the behaviour is unchanged so invalid configuration can rather be fixed
than ignored.
@Byron Byron marked this pull request as ready for review May 17, 2024 07:35
@Byron Byron merged commit 3c21741 into main May 17, 2024
19 checks passed
@Byron Byron deleted the fix-empty-excludes-file branch May 17, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants