-
-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix msrv: Run msrv checks with minimal versions #1541
Conversation
Since it is possible to for dependencies to bump MSRV in patch release, msrv checking should use the minimal versions supported by gix. Users cares deeply about msrv can also pin them to the minimal versions to maintain their current msrv.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the initiative! I can use any help I can get to get this dependency-monster under control.
Even though it was initially reproducing the Is this something you can figure out? I tried, but it doesn't make sense after all. |
I think the version of Since the error is from |
This seems to be more compatible to nightly versions of the compiler.
looks like libz-ng is too old? |
…test releases. That way, those compiling with `-Zminimal-versions` have higher chances of it to work. See GitoxideLabs/gitoxide#1541 for reference.
Thanks a lot for the encouragement! I ended up running the However, now it seems to show drift in the This shows that |
Yeah it's somewhat transitive, I think we can reduce this burden by running If more crates start using it, then it would be detected early on instead of passing it to downstream. |
@Byron I opened rust-lang/flate2-rs#425 to add |
Thanks - once it fails I plan to put my 'fix' from the other PR on top of it, bump the version, merge and create a new release. Then this PR should be unblocked (or is blocked by something else :D). |
…test releases. That way, those compiling with `-Zminimal-versions` have higher chances of it to work. See GitoxideLabs/gitoxide#1541 for reference.
Needs rust-lang/flate2-rs#425 to continue, which needs |
…test releases. That way, those compiling with `-Zminimal-versions` have higher chances of it to work. See GitoxideLabs/gitoxide#1541 for reference.
Since it is possible to for dependencies to bump MSRV in patch release, msrv checking should use the minimal versions supported by gix.
Users cares deeply about msrv can also pin them to the minimal versions to maintain their current msrv.
This would have also help discover bug in #1538