Changes needed to use gitoxide for radicle-link test setup #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Byron
force-pushed
the
repository-integration
branch
from
2abad3a to
6d0bedd
Compare
9 tasks
…in all relevant crates. That way server binaries don't have to deal with the extra dependencies.
…just to use its lock mode.
…to simulate the initial commit situation which led to improvements in the provided API.
…because it still spams the disk anyway, and having it might improve build speeds.
…n't is lacking… …as we need a constraint that can't be represented with the current system.
…maybe this is where we should see that mutating this just to use it in reflogs isn't the way.
…to avoid bugs that we otherwise would have introduced (without a failing test mind you).
…such as the distinction between packed and loose refs as well as how consumers can use references. This means git-repository will have a much simpler time to deal with differences between file stores and reftables stores and it will be easier to grant access to peeling and symref following.
Follow module structure
…and it works like it should. This shows that finding needs namespace support if it is even something that we need.
… namespaces… …which doesn't work unless the fully qualified namespaced name is provided. This is correct behaviour. To fix this, one would have to search in a known namespace, which can be done with some refactoring. This would allow refs to be found by partial name. However, doing this is only useful for client applications who want to namespace a repository and allow the user to search by partial name.
…as nobody should really need this. It's available for the top-level overlay iterator though.
…now that namespaces are rooted in the store transactions don't have to handle them anymore.
…which surprisingly enough works with our kind of caching system. Amazing. Does it really work though?
This allows to read packs which are differently named which is what git and libgit2 do, too.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git-actor::Signature::now_local_or_utc()Access::write_object(…)git_object::Object::into_*git_object::Object::try_into_*git_ref::transaction::PreviousValue- more options to specify expected value constraintreftabletoo and keep things much simplergit_repository::Easy::commit(…)Easy::head()APIgit-ref::Referencefile::Store access cleanupeasy::Reference::log*()reflog access (for tests)Easy::iter_references()into_fully_peeled_id()foreasy::ReferenceEasy::set_namespce()follow()