Skip to content

Conversation

@yuki0iq
Copy link
Contributor

@yuki0iq yuki0iq commented Oct 23, 2025

It is part of doc_cfg feature since rust-lang/rust#138907

Should fix docs.rs build. I have tested locally with cargo docs-rs -p gix and documentation builds correctly

Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fix, it's much appreciated!

It's bad timing that docs.rs is down today, so I can't see how the documentation looks like now. But maybe there is nothing do to the failure, and that's it.

With that said, I will be using this PR to push new versions of the affected crates as well.

Please note that for my own convenience, I edited your commit message (while breaking its signature) to put the commit-message into the changelog automatically.

It is part of `doc_cfg` feature since rust-lang/rust#138907

This fixes the docs.rs build
…eatures v0.44.1, gix-hash v0.20.1, gix-object v0.51.1, gix-glob v0.22.1, gix-attributes v0.28.1, gix-packetline-blocking v0.19.3, gix-commitgraph v0.30.1, gix-archive v0.23.1, gix-tempfile v19.0.1, gix-index v0.42.1, gix-config-value v0.15.3, gix-ignore v0.17.1, gix-worktree v0.43.1, gix-diff v0.54.1, gix-ref v0.54.1, gix-sec v0.12.2, gix-config v0.47.1, gix-url v0.33.1, gix-credentials v0.31.1, gix-mailmap v0.27.4, gix-revision v0.36.1, gix-pack v0.61.1, gix-odb v0.71.1, gix-packetline v0.19.3, gix-transport v0.49.1, gix-protocol v0.52.1, gix-status v0.21.1, gix v0.74.1
@Byron Byron enabled auto-merge October 23, 2025 07:30
@Byron Byron merged commit fbf9c39 into GitoxideLabs:main Oct 23, 2025
29 checks passed
@yuki0iq
Copy link
Contributor Author

yuki0iq commented Oct 23, 2025

That's a bit weird, but I feel like all links in changelog got corrupted and now point to my fork instead of upstream even in historical entries

@Byron
Copy link
Member

Byron commented Oct 23, 2025

Oh no :D - next time they are regenerated, they will be fixed, I think.
And even if not, it's a nice historical artefact of tooling gone slightly wrong 😁.

@EliahKagan
Copy link
Member

EliahKagan commented Oct 23, 2025

but I feel like all links in changelog got corrupted and now point to my fork

The good news is that they are full OIDs, so they are not likely to ever point to a different/wrong commit, though in the event that you were ever to delete your fork, they would break.

(Renaming your fork or even moving it into an organization or otherwise transferring it would probably not break them, though, because GitHub makes URLs with an old repository name redirect to corresponding URLs with the new repository name, such as how Byron/gitoxide URLs redirect to GitoxideLabs/gitoxide URLs.)

next time they are regenerated, they will be fixed, I think.

@Byron I should be able to fix these easily to be GitoxideLabs/gitoxide instead of yuki0iq/gitoxide URLs. Do you prefer I not do so?

My argument for doing so is that extra changes across tags may make it harder for people to look at what changed when comparing two tags.

Of course, if it is known that these changelogs will all be regenerated before the next tag, then no such confusion would arise, whether or not they are fixed before then.

@Byron
Copy link
Member

Byron commented Oct 24, 2025

Thank you @EliahKagan, but I think it's Ok to keep it until someone complains, and assuming it will be auto-fixed next time. I think it regenerates old blocks anyway so in a month it's all gone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants