fix: prevent dots from being URL-encoded in userinfo #2280
Merged
+68
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dots (
.) in usernames and passwords were incorrectly URL-encoded as%2Eduring serialization. Fixes gitbutlerapp/gitbutler#11419.Changes
gix-url/src/lib.rs: ReplaceNON_ALPHANUMERICencoding with RFC 3986-compliantUSERINFO_ENCODE_SETthat preserves unreserved chars (. - _ ~)gix-url/tests/url/parse/http.rs: Add roundtrip tests for dots in username, password, and bothgix-url/tests/url/parse/ssh.rs: Add roundtrip test for dots in SSH usernamesgix-url/tests/fixtures/make_baseline.sh: Add baseline URLs with dotted usernames (ssh://user.name@host/repo,git://user.name@host/repo,user.name@host:repo)Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.