fetch pack #539
Merged
fetch pack #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maybe this helps to understand how ls-refs extensions can be used.
…refspec's source. #(450)
…450) This can greatly reduce the amount of refs sent.
That way, we can still see all remote refs if desired.
The latter could alter the way protocol interactions work, but we might already do it correctly.
…450) …that would force it to be 'static, which is something we excplicitly cannot have. We need references to be contained within, if I remember correctly.
#450) It' can't fail, so no need to return `Result<_, Infallible>`.
…450) After all, this is somewhat optional and the server stops once we disconnect, and the called function may already have performed that action.
The overhead required to make it work isn't worth the logic we are enabling. Instead, it's OK to re-implement custom logic on the consumer side based on this one.
…ansport_mut().configure()`. (#450) This eventually will be used for all kinds of http settings and remote settings, goal being to be zero-conf since everything comes from git-config.
…he right way. (#450) This works for all cases were a single program is compiled and there are no dll boundaries, which I think is the way it will be for quite a while.
… heads as well. (#450)
…isition::Fail` instances. (#450) This allows to configure the file-ref lock failure mode differently from the packed-refs lock failure mode, which is exactly what `git` does as well defaulting them to 100ms and 1000ms till lock acquisition gives up.
Previously it picked up the users configuration as it was loading the standard git configuration, instead of the restricted one.
Unfortunately all tests are now liable to picking up GIT_ environment variables which will affect those that create commits. Maybe better control them right away or find another way to set the time.
…d stability. (#450) Note that this is only required as we freeze time using environment variables, so `GIT_` is now allowed when opening repos. There would be another way, which is controlling exactly what restricted means.
…o need it. (#450) This means, other tests are once again isolated by default
This is tested for worktrees as well, including deleted ones, and validated by hand the git produces the same results.
Conflicts: git-transport/src/client/blocking_io/http/mod.rs
Remove spec_index field as it can be derived from the corresponding mapping.
…lues of references. (#450) That's more convenient than matching on the enum.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An abstraction to allow fetching a pack into bare and non-bare repositories.
Tasks
ref-prefixargument to reduce list of sent tips for good measuregit-protocolNext
fetchingix remote refsto provide more detailed information about what would be done to refsOut of scope