tempfile upgrade #762
Merged
tempfile upgrade #762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…339) This change also consolidates all signal handling into its own module called `signal` to provide reusable handlers and as well as well as signal initialization. Note that the functions to cleanup tempfiles don't interact with the signal registry, hence they still can be called without the `signals` feature enabled. Note that this change sneakily fixes a bug that could have caused a `write_all()` on a tempfile that was removed by a signal to enter an infinite loop.
Byron
force-pushed
the
tempfile-upgrades
branch
from
259520a to
c6785fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks
create examples to show high-level and low-level handlers in action withsignal-hookgit-repositoryand make sure it's clear how handlers are supposed to be used there, maybe have a centralsetup()function applications should call with some options to get started quickly, without locking them out of integrating with their own interrupt handlers. Assure the latter can happen.Maintenance