gix corpus MVP
#897
Merged
gix corpus MVP
#897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the obtained list is empty, we update against that empty list which fills the repositories tables for the first time. Additionally we provide a new sub-command to refresh the list (additions only).
This properly communicates that they will only be called once per thread, while providing more options to the implementor.
Byron
force-pushed
the
corpus
branch
3 times, most recently
from
fe2eaea
to
5cbc464
Compare
This API is based on `tracing-core`, not on tracing, and provides a limited API that is always available, while being a no-op if `tracing` isn't enabled. That way, plumbing crates can add instrumentation at will.
This is just the beginning and more crates will integrate with it over time.
Otherwise `time-core` doesn't build anymore And we don't make it a breaking change as this is what the community seems to settle with.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #858.
Tasks
gixas part of the CLIrefreshcommand to force re-reading all repos in a corpustracing-coreto collect open-repo timing information and collect it with each run--traceflag forgixto print trees usingprogressgix-featurestoggle for enabling tracing spans usage (with or withouttracing-core)gix-features/tracingand tactical tracing usage ingixwithgix_features::tracingIdea
tracing-corewould allow to slowly build-out timing information forgixand make it ready for server-applications which would usetracing-coreas well. It can be very useful to autoamicallyprovide call-trees with timings along with complex and arbitrary metadata.
prodash-tracingto digest spans/events and useprogress.infoto visually create a log of spans and events with timings. That way they could at least be represented without interfering with progress.