-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
image doesn't load in verification wizard #2546
Comments
…description related to Giveth/giveth-dapp#2546
As I talked with @mohammadranjbarz, this issue needs a minor change in backend, so I move it to in progress. |
@RamRamez |
Thanks @mohammadranjbarz. I move this issue to UAT test. @divine-comedian Can you test it? |
testing now on I can see the image is no longer broken but it looks like default image isn't quite right. This is how my project looks on and this is the image shows up in the verification wizard - ideally a user who chooses any of these default giveth.io project images would have the same image when they migrate their project to giveth TRACE. I will note that these default images might change as we redesign our platforms in the future |
Yeah because the images are numbers in givethio Showing exactly that one make our codes a little messy, but if the product need it we can do it ( although I think if a project doesn't have an image in giveth it would not have lots of chances to become verified) |
@divine-comedian Thanks for reporting this. I have reported this issue in IO #261. |
You raise a really great point. I'm okay with calling the present state "good enough" because you're right, it's very unlikely a project would succeed verification without a unique photo. |
I'm verifying my project on the wizard. I used one of the default giveth.io project photos.
when I arrive at the wizard my image doesn't show up where it normally should, it looks like its broken -
The text was updated successfully, but these errors were encountered: