Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image doesn't load in verification wizard #2546

Open
divine-comedian opened this issue Sep 25, 2021 · 10 comments
Open

image doesn't load in verification wizard #2546

divine-comedian opened this issue Sep 25, 2021 · 10 comments
Assignees
Labels
bug Issues that arise due to code architecture

Comments

@divine-comedian
Copy link
Collaborator

I'm verifying my project on the wizard. I used one of the default giveth.io project photos.

when I arrive at the wizard my image doesn't show up where it normally should, it looks like its broken -

image.png

@divine-comedian divine-comedian added the bug Issues that arise due to code architecture label Sep 25, 2021
@RamRamez RamRamez self-assigned this Sep 25, 2021
@RamRamez
Copy link
Collaborator

RamRamez commented Sep 25, 2021

This issue is actually related to giveth.io. If user uses app default SVGs as a project image, a number will be saved in DB except of SVG url. That is weird!

image

@RamRamez
Copy link
Collaborator

RamRamez commented Sep 25, 2021

I made those images hidden in verification in PR #2547

We should fix this in giveth.io (#261)

@mohammadranjbarz
Copy link
Collaborator

I made those images hidden in verification in PR #2547

We should fix this in giveth.io (#261)

@RamRamez
I've fixed that in the backend, could you confirm if it is ok?

@mohammadranjbarz mohammadranjbarz self-assigned this Sep 27, 2021
@RamRamez
Copy link
Collaborator

As I talked with @mohammadranjbarz, this issue needs a minor change in backend, so I move it to in progress.

@mohammadranjbarz
Copy link
Collaborator

@RamRamez
Could you test it again?
We merged another PR and I created a verified campaign (with no image in givethio) and it was ok

https://develop.giveth.io/campaign/demo-slug

@RamRamez
Copy link
Collaborator

Thanks @mohammadranjbarz. I move this issue to UAT test.

@divine-comedian Can you test it?

@divine-comedian
Copy link
Collaborator Author

testing now on develop.giveth.io

I can see the image is no longer broken but it looks like default image isn't quite right.

This is how my project looks on next.giveth.io

image

and this is the image shows up in the verification wizard -

image

ideally a user who chooses any of these default giveth.io project images would have the same image when they migrate their project to giveth TRACE.

I will note that these default images might change as we redesign our platforms in the future

image

@mohammadranjbarz
Copy link
Collaborator

testing now on develop.giveth.io

I can see the image is no longer broken but it looks like default image isn't quite right.

This is how my project looks on next.giveth.io

image

and this is the image shows up in the verification wizard -

image

ideally a user who chooses any of these default giveth.io project images would have the same image when they migrate their project to giveth TRACE.

I will note that these default images might change as we redesign our platforms in the future

image

Yeah because the images are numbers in givethio
for instance "1", "2" ,...
we don't know what is it, so we set our default image for that. ( doesn't matter whats the image in givethio)

Showing exactly that one make our codes a little messy, but if the product need it we can do it ( although I think if a project doesn't have an image in giveth it would not have lots of chances to become verified)
@MoeNick what do you think?

@RamRamez
Copy link
Collaborator

RamRamez commented Sep 28, 2021

@divine-comedian Thanks for reporting this.

I have reported this issue in IO #261.
We should fix it there.
If we fix it there, the default images will be automatically shown here.

@divine-comedian
Copy link
Collaborator Author

@mohammadranjbarz

You raise a really great point. I'm okay with calling the present state "good enough" because you're right, it's very unlikely a project would succeed verification without a unique photo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues that arise due to code architecture
Projects
None yet
Development

No branches or pull requests

3 participants