change givbacks eligible tags conditions

[RamRamez]

Summary by CodeRabbit

• New Features
  • Donations meeting or exceeding $5 USD now qualify for enhanced rewards processing, ensuring that the additional benefits are applied accurately.

[coderabbitai]

Walkthrough

This pull request introduces a new constant GIVBACKS_ELIGIBLE_MIN_DONATION_USD with a value of 5 in a validators file. The constant is then imported into donation-related service files to control the logic for determining if a donation qualifies for Givbacks. In both the cron job and donation service, the value of donation.powerRound is conditionally incremented based on whether the donation’s USD value meets or exceeds the threshold, with the eligibility logic encapsulated in a new variable.

Changes

File(s)	Change Summary
src/constants/validators.ts	Added new constant GIVBACKS_ELIGIBLE_MIN_DONATION_USD with a value of 5.
src/services/cronJobs/importLostDonationsJob.ts src/services/donationService.ts	Imported the new constant and updated the logic to conditionally increment the GIVbacksRound attribute based on whether the donation’s USD value meets the specified threshold.

Sequence Diagram(s)

sequenceDiagram
    participant DS as Donation Service / Cron Job
    participant V as Validators Constant
    participant NL as Notification Logic

    DS->>V: Retrieve GIVBACKS_ELIGIBLE_MIN_DONATION_USD (5)
    DS->>DS: Evaluate donation.valueUsd >= 5
    alt Donation is eligible
        DS->>NL: Set GIVbacksRound = donation.powerRound + 1
    else Donation is not eligible
        DS->>NL: Set GIVbacksRound = undefined
    end

Loading

Possibly related PRs

• Implement allocatedGivbacks function #1808: Involves changes using the GIVBACKS_ELIGIBLE_MIN_DONATION_USD constant to determine donation eligibility in a similar context.

Suggested reviewers

• kkatusic

Poem

I hopped through lines of code with cheer,
Adding a constant so the logic's clear.
With checks for donations, big or small,
I nudge the power round to stand tall.
Code and bunny dance in a joyful affair! 🐰

Happy hopping through the changes!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 415927f and ceefd14.

📒 Files selected for processing (3)

• src/constants/validators.ts (1 hunks)
• src/services/cronJobs/importLostDonationsJob.ts (3 hunks)
• src/services/donationService.ts (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: test

🔇 Additional comments (3)

src/constants/validators.ts (1)

6-6: LGTM! Well-defined constant for Givbacks eligibility.

The constant is appropriately placed and follows the naming convention of other constants in the file.

src/services/cronJobs/importLostDonationsJob.ts (1)

254-267: LGTM! Clear implementation of Givbacks eligibility check.

The eligibility check is well-implemented, and the comment about powerRound being 1 behind givbacks round is helpful for understanding the logic.

src/services/donationService.ts (1)

296-308: LGTM! Consistent implementation of Givbacks eligibility check.

The eligibility check is well-implemented and maintains consistency with the importLostDonationsJob.ts implementation.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.