Avoid the need to have 2-step deployments to get rid of a module

[AronNovak]

#735

Status

[AronNovak]

We should try it at a client project where this need arises next time.

[dipakmdhrm]

Suggested change

	$uninstall_success = $this->taskExec("terminus remote:drush $pantheon_terminus_environment -- pm:uninstall " . implode(' ', $modules_to_uninstall) . " --yes")
	->run()
	->getExitCode();
	$needs_revert = !$uninstall_success;
	$needs_revert = $this->taskExec("terminus remote:drush $pantheon_terminus_environment -- pm:uninstall " . implode(' ', $modules_to_uninstall) . " --yes")
	->run()
	->getExitCode();

Exit code 0 is success.

[mariano-dagostino]

Based on some real tests this is not working as expected. It seems negating the exit code is not working.

[AronNovak]

@mariano-dagostino Thanks for trying it out! Do you have the full build log possibly? As I see the build was restarted in debug mode, so I cannot access it anymore.
Anyways, I will take a look how it can happen that it does not detect the status properly.