Rename the constant to

og.module

@@ -53,7 +53,7 @@ function og_entity_insert(EntityInterface $entity) {
 
   // Other modules that implement hook_entity_insert() might already have
   // created a membership ahead of us.
-  if (!Og::getMembership($entity, $entity->getOwner(), OgMembershipInterface::STATES)) {
+  if (!Og::getMembership($entity, $entity->getOwner(), OgMembershipInterface::ALL_STATES)) {
     $membership = Og::createMembership($entity, $entity->getOwner());
     $membership->save();
   }

src/Cache/Context/OgMembershipStateCacheContext.php

@@ -77,7 +77,7 @@ public function getContext() {
     }
 
     /** @var \Drupal\og\OgMembershipInterface $membership */
-    $membership = $this->membershipManager->getMembership($group, $this->user, OgMembershipInterface::STATES);
+    $membership = $this->membershipManager->getMembership($group, $this->user, OgMembershipInterface::ALL_STATES);
     return $membership ? $membership->getState() : self::NO_CONTEXT;
   }
 

src/Controller/SubscriptionController.php

@@ -157,7 +157,7 @@ public function subscribe($entity_type_id, EntityInterface $group, OgMembershipT
   public function unsubscribe(ContentEntityInterface $group) {
     $user = $this->currentUser();
 
-    if (!$membership = Og::getMembership($group, $user, OgMembershipInterface::STATES)) {
+    if (!$membership = Og::getMembership($group, $user, OgMembershipInterface::ALL_STATES)) {
       // User is not a member.
       throw new AccessDeniedHttpException();
     }

src/MembershipManager.php

@@ -83,7 +83,7 @@ public function getUserGroups(AccountInterface $user, array $states = [OgMembers
   public function getMemberships(AccountInterface $user, array $states = [OgMembershipInterface::STATE_ACTIVE]) {
     // When an empty array is passed, retrieve memberships with all possible
     // states.
-    $states = $states ?: OgMembership::STATES;
+    $states = $states ?: OgMembership::ALL_STATES;
 
     // Get a string identifier of the states, so we can retrieve it from cache.
     sort($states);

src/MembershipManagerInterface.php

@@ -63,7 +63,7 @@ public function getUserGroups(AccountInterface $user, array $states = [OgMembers
    * @param array $states
    *   (optional) Array with the states to return. Defaults to only returning
    *   active memberships. In order to retrieve all memberships regardless of
-   *   state, pass `OgMembershipInterface::STATES`.
+   *   state, pass `OgMembershipInterface::ALL_STATES`.
    *
    * @return \Drupal\og\OgMembershipInterface[]
    *   An array of OgMembership entities, keyed by ID.
@@ -80,7 +80,7 @@ public function getMemberships(AccountInterface $user, array $states = [OgMember
    * @param array $states
    *   (optional) Array with the states to return. Defaults to only returning
    *   active memberships. In order to retrieve all memberships regardless of
-   *   state, pass `OgMembershipInterface::STATES`.
+   *   state, pass `OgMembershipInterface::ALL_STATES`.
    *
    * @return \Drupal\og\OgMembershipInterface|null
    *   The OgMembership entity. NULL will be returned if no membership is

src/Og.php

@@ -135,7 +135,7 @@ public static function createField($plugin_id, $entity_type, $bundle, array $set
    * @param array $states
    *   (optional) Array with the states to return. Defaults to only returning
    *   active memberships. In order to retrieve all memberships regardless of
-   *   state, pass `OgMembershipInterface::STATES`.
+   *   state, pass `OgMembershipInterface::ALL_STATES`.
    *
    * @return \Drupal\og\OgMembershipInterface[]
    *   An array of OgMembership entities, keyed by ID.
@@ -156,7 +156,7 @@ public static function getMemberships(AccountInterface $user, array $states = [O
    * @param array $states
    *   (optional) Array with the states to return. Defaults to only returning
    *   active memberships. In order to retrieve all memberships regardless of
-   *   state, pass `OgMembershipInterface::STATES`.
+   *   state, pass `OgMembershipInterface::ALL_STATES`.
    *
    * @return \Drupal\og\OgMembershipInterface|null
    *   The OgMembership entity. NULL will be returned if no membership is

src/OgMembershipInterface.php

@@ -41,7 +41,7 @@ interface OgMembershipInterface extends ContentEntityInterface, EntityOwnerInter
   /**
    * An array containing all possible group membership states.
    */
-  const STATES = [self::STATE_ACTIVE, self::STATE_PENDING, self::STATE_BLOCKED];
+  const ALL_STATES = [self::STATE_ACTIVE, self::STATE_PENDING, self::STATE_BLOCKED];
 
   /**
    * The default group membership type that is the bundle of group membership.