Skip to content
This repository has been archived by the owner on Aug 18, 2024. It is now read-only.

Membership entities are double cached in MembershipManager #445

Closed
pfrenssen opened this issue Dec 11, 2018 · 0 comments
Closed

Membership entities are double cached in MembershipManager #445

pfrenssen opened this issue Dec 11, 2018 · 0 comments

Comments

@pfrenssen
Copy link
Contributor

MembershipManager::getMemberships() caches the fully loaded OgMembership entities, but this is pointless since they are already cached in EntityStorageBase::loadMultiple().

Let's save some precious memory by only caching the entity IDs instead of the full entities.
pfrenssen added a commit that referenced this issue Dec 11, 2018
@pfrenssen
Avoid double caching of OgMembership entities.
429ba54 
Fixes #445
@pfrenssen pfrenssen mentioned this issue Dec 11, 2018
Merged
pfrenssen added a commit that referenced this issue Dec 11, 2018
@pfrenssen
Avoid double caching of OgMembership entities.
0dd68c4 
Fixes #445
pfrenssen added a commit that referenced this issue Dec 11, 2018
@pfrenssen
Avoid double caching of OgMembership entities.
2930603 
Fixes #445
pfrenssen added a commit that referenced this issue Dec 12, 2018
@pfrenssen
Avoid double caching of OgMembership entities.
a45bde1 
Fixes #445
pfrenssen added a commit that referenced this issue Dec 12, 2018
@pfrenssen
Avoid double caching of OgMembership entities.
859f0fa 
Fixes #445
pfrenssen added a commit that referenced this issue Dec 12, 2018
@pfrenssen
Avoid double caching of OgMembership entities.
65c95a8 
Fixes #445
DiDebru pushed a commit to ueberbit/og that referenced this issue Apr 23, 2019
@pfrenssen @DiDebru
Avoid double caching of OgMembership entities.
9e1e3f6 
Fixes Gizra#445
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pfrenssen