Skip to content
This repository has been archived by the owner on Aug 18, 2024. It is now read-only.

User::load() calls should be avoided in classes #546

Closed
3 tasks done
pfrenssen opened this issue Jul 23, 2019 · 1 comment
Closed
3 tasks done

User::load() calls should be avoided in classes #546

pfrenssen opened this issue Jul 23, 2019 · 1 comment
Labels
Clean-up Drupal 8
Milestone
8.x-1.0-alpha5

Comments

@pfrenssen
Copy link
Contributor

pfrenssen commented Jul 23, 2019 •
edited by MPParsley
Loading

  • Remove the following line from phpcs-ruleset.xml.dist:
    <exclude name="DrupalPractice.Objects.GlobalClass.GlobalClass" />
  • Run ./vendor/bin/phpcs
  • Fix all reported warnings.
@pfrenssen pfrenssen mentioned this issue Jul 23, 2019
Merged
@ghost ghost mentioned this issue Dec 23, 2019
Merged
kbrodej added a commit to kbrodej/og that referenced this issue Feb 7, 2020
@kbrodej
Merge branch 'hotfix/Dependecy-injection-#546' into DI-Gizra#546
2eb8af3
kbrodej added a commit to kbrodej/og that referenced this issue Feb 7, 2020
@kbrodej
Merge pull request #3 from kbrodej/DI-#546
242426f 
Di Gizra#546
pfrenssen added a commit that referenced this issue Feb 9, 2020
@pfrenssen
Merge pull request #601 from kbrodej/hotfix/Dependecy-injection-#546
873a140 
`User::load()` calls should be avoided in classes #546 fix
@MPParsley
Copy link
Collaborator

Solved in #601

@pfrenssen pfrenssen added this to the 8.x-1.0-alpha5 milestone Aug 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Clean-up Drupal 8
Projects
None yet
Milestone
8.x-1.0-alpha5
Development

No branches or pull requests
2 participants
@pfrenssen @MPParsley