This repository has been archived by the owner on Aug 18, 2024. It is now read-only.

Global constants should not be used #550

Closed

2 of 3 tasks

pfrenssen opened this issue Jul 23, 2019 · 0 comments · Fixed by #612

Closed

2 of 3 tasks

Global constants should not be used #550

pfrenssen opened this issue Jul 23, 2019 · 0 comments · Fixed by #612

Labels

Clean-up Drupal 8

Milestone

Contributor

pfrenssen commented Jul 23, 2019 •

edited by MPParsley

Loading

Remove the following line from phpcs-ruleset.xml.dist:
<exclude name="DrupalPractice.Constants.GlobalDefine.GlobalConstant" />
Run ./vendor/bin/phpcs
Fix all reported warnings.

The text was updated successfully, but these errors were encountered:

pfrenssen added Drupal 8 Clean-up labels

pfrenssen mentioned this issue

Start using the DrupalPractice set of codesniffer rules #551

Merged

MPParsley added a commit that referenced this issue


          550 Remove global constants

fe6afd6

Fix #550

MPParsley mentioned this issue

550 Remove global constants #612

Merged

pfrenssen closed this as completed in #612

pfrenssen added this to the 8.x-1.0-alpha5 milestone

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.