Added option in og_context_plugin_argument_default_group_context.inc to accompany the permission rewrite in og_context(). #131

alesrebec · 2016-06-23T09:37:29Z

Issue #121

Issue #2151015 by hass, tmckeown, iaminawe: Migrate warnings

…roup_context.inc to accompany the permission rewrite in og_context().

amitaibu · 2016-06-23T09:38:50Z

og_context/includes/views/handlers/og_context_plugin_argument_default_group_context.inc

@@ -32,13 +32,21 @@ class og_context_plugin_argument_default_group_context extends views_plugin_argu
      '#default_value' => $this->options['group_type'],
      '#description' => t('Determine what entity type that group should be of.')
    );
+    $form['check_access'] = array(


you need to define it also in option_definition

alesrebec · 2016-06-23T10:16:18Z

@amitaibu thanks for the quick review.
For some reason travis ci can't test it right now..
Trying to discover channel pear.drush.org over https:// instead Discovery of channel "pear.drush.org" failed (channel-add: Cannot open "https://pear.drush.org/channel.xml" (Connection to pear.drush.org:443 failed: php_network_getaddresses: getaddrinfo failed: Name or service not known)) The command "pear channel-discover pear.drush.org" failed and exited with 1 during . Your build has been stopped.
https://travis-ci.org/Gizra/og/builds/139718693

The commit with option_definition should be fine though.

amitaibu · 2016-06-23T10:21:14Z

og_context/includes/views/handlers/og_context_plugin_argument_default_group_context.inc

@@ -32,13 +33,20 @@ class og_context_plugin_argument_default_group_context extends views_plugin_argu
      '#default_value' => $this->options['group_type'],
      '#description' => t('Determine what entity type that group should be of.')
    );
+    $form['check_access'] = array(
+      '#type' => 'select',


this should be a checkbox

alesrebec · 2016-06-23T11:27:35Z

Hope it's fine now.
Looks like all test tests are failing now because of unreachable https://pear.drush.org/channel.xml file.

amitaibu · 2016-06-23T11:29:56Z

Lots of karma points, if you'll be able to fix the travis tests in another PR :)

amitaibu · 2016-06-23T11:37:13Z

Can you also please attach a screenshot showing the new option.

alesrebec · 2016-06-23T15:30:45Z

amitaibu · 2016-07-04T11:21:40Z

blocked by #133

alesrebec · 2016-09-06T07:20:37Z

Is this one still blocked?

amitaibu · 2016-09-06T08:48:20Z

I'm afraid so :/ @nirgn975 is working on #133 - but if you have time to give it a look as-well, it might speed it up.

alesrebec · 2016-09-06T10:46:41Z

Sorry, don't use Travis so I might be unhelpful with this.
Also we can mark is as blocked by #134. The debate and progress of #133 is all there.

kyletaylored · 2017-06-22T21:22:06Z

I recently ran into this issue that needs the disable the check_access, and while I just wrote it into my own Views plugin, I wanted to follow up and check the status on this PR!

alesrebec · 2017-07-11T12:40:55Z

According to #255 this test can be restarted.
@amitaibu can you restart it so we don't need to open a new PR?

jorrit · 2017-07-11T12:42:40Z

If you amend the commit and force push it Travis will restart the test.

amitaibu · 2017-07-11T12:45:05Z

Try to merge with 7.x-2.x, where Travis is now fixed.

…ct to checkbox and changed description to match the change.

alesrebec · 2017-07-11T13:49:45Z

It's a pass.

amitaibu · 2017-07-11T14:24:45Z

Thanks 👍

alesrebec · 2017-07-11T14:36:34Z

You're welcome. It's finally in.
You probably need to fix the authorship of all the commits taken from github repo.
https://www.drupal.org/node/13446/commits

amitaibu · 2017-07-11T14:38:36Z

Sorry. That's weird, usually the authorship is working correctly when I just push.

alesrebec · 2017-09-25T12:52:24Z

@amitaibu Any plans to release 7.x-2.10 at DrupalCon Vienna's sprints this week?
There are quite some important patches missing in the current stable version (7.x-2.9) released 5 months from ago.
https://github.com/Gizra/og/commits/7.x-2.x

amitaibu · 2017-10-01T11:08:04Z

Post DrupalCon, but I'll try to push a new version soon.

alesrebec · 2018-03-28T13:05:50Z

Almost shit my pants when I noticed OG 7.x-2.9 is 2 years old in few days.
So many fixes and improvements that were already merged 7.x-2.x are still missing from stable 7.x-2.10 release.
I'm living with patches in this project for a long time now and I'm sure I'm not the only one.
@amitaibu if you need help with it, just say.
We are all 110% busy with work and kids, but we'll risk one night for this. Count me in.

amitaibu · 2018-03-29T16:59:40Z

@amitaibu if you need help with it, just say.

@alesrebec I need help :) How about I'll allow you to coordinate this release (and the possible post-release issues) - would you be up for it?

alesrebec · 2018-03-29T22:24:10Z

Well, I kinda gave my word to help, sooo.. yes, I'm up for it.

amitaibu · 2018-04-01T19:14:42Z

@alesrebec great! Will you be in the upcoming DrupalCon?

Otherwise, can you ping me via email amitai@gizra.com -- and we'll coordinate this?

alesrebec added 2 commits June 23, 2016 11:20

Merge pull request #1 from Gizra/7.x-2.x

f9e77de

Issue #2151015 by hass, tmckeown, iaminawe: Migrate warnings

Issue Gizra#121: Added option in og_context_plugin_argument_default_g…

4982107

…roup_context.inc to accompany the permission rewrite in og_context().

amitaibu reviewed Jun 23, 2016
View reviewed changes

Issue Gizra#121: Added option_definition for ['check_access'].

0e33e39

amitaibu reviewed Jun 23, 2016
View reviewed changes

Issue Gizra#121: Changed form element type for check_access from sele…

16be973

…ct to checkbox and changed description to match the change.

alesrebec force-pushed the 7.x-2.x branch from d2590a3 to 16be973 Compare July 11, 2017 12:57

amitaibu merged commit 60d9f3b into Gizra:7.x-2.x Jul 11, 2017

alesrebec mentioned this pull request Apr 17, 2018

#121 - og_context() default value set to FALSE. #122

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added option in og_context_plugin_argument_default_group_context.inc to accompany the permission rewrite in og_context(). #131

Added option in og_context_plugin_argument_default_group_context.inc to accompany the permission rewrite in og_context(). #131

alesrebec commented Jun 23, 2016

amitaibu Jun 23, 2016

alesrebec commented Jun 23, 2016 •

edited

Loading

amitaibu Jun 23, 2016

alesrebec Jun 23, 2016

alesrebec commented Jun 23, 2016

amitaibu commented Jun 23, 2016

amitaibu commented Jun 23, 2016

alesrebec commented Jun 23, 2016

amitaibu commented Jul 4, 2016

alesrebec commented Sep 6, 2016

amitaibu commented Sep 6, 2016

alesrebec commented Sep 6, 2016

kyletaylored commented Jun 22, 2017

alesrebec commented Jul 11, 2017

jorrit commented Jul 11, 2017

amitaibu commented Jul 11, 2017

alesrebec commented Jul 11, 2017

amitaibu commented Jul 11, 2017

alesrebec commented Jul 11, 2017

amitaibu commented Jul 11, 2017

alesrebec commented Sep 25, 2017

amitaibu commented Oct 1, 2017

alesrebec commented Mar 28, 2018 •

edited

Loading

amitaibu commented Mar 29, 2018

alesrebec commented Mar 29, 2018

amitaibu commented Apr 1, 2018

Added option in og_context_plugin_argument_default_group_context.inc to accompany the permission rewrite in og_context(). #131

Added option in og_context_plugin_argument_default_group_context.inc to accompany the permission rewrite in og_context(). #131

Conversation

alesrebec commented Jun 23, 2016

amitaibu Jun 23, 2016

Choose a reason for hiding this comment

alesrebec commented Jun 23, 2016 • edited Loading

amitaibu Jun 23, 2016

Choose a reason for hiding this comment

alesrebec Jun 23, 2016

Choose a reason for hiding this comment

alesrebec commented Jun 23, 2016

amitaibu commented Jun 23, 2016

amitaibu commented Jun 23, 2016

alesrebec commented Jun 23, 2016

amitaibu commented Jul 4, 2016

alesrebec commented Sep 6, 2016

amitaibu commented Sep 6, 2016

alesrebec commented Sep 6, 2016

kyletaylored commented Jun 22, 2017

alesrebec commented Jul 11, 2017

jorrit commented Jul 11, 2017

amitaibu commented Jul 11, 2017

alesrebec commented Jul 11, 2017

amitaibu commented Jul 11, 2017

alesrebec commented Jul 11, 2017

amitaibu commented Jul 11, 2017

alesrebec commented Sep 25, 2017

amitaibu commented Oct 1, 2017

alesrebec commented Mar 28, 2018 • edited Loading

amitaibu commented Mar 29, 2018

alesrebec commented Mar 29, 2018

amitaibu commented Apr 1, 2018

alesrebec commented Jun 23, 2016 •

edited

Loading

alesrebec commented Mar 28, 2018 •

edited

Loading