This repository has been archived by the owner on Aug 18, 2024. It is now read-only.
Avoid exception in case a membership is already found. #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitaibu
reviewed
Aug 8, 2017
og.module
Outdated
| $membership = Og::createMembership($entity, $entity->getOwner()); | ||
| $membership->save(); | ||
| // Other modules might interfere and create a membership. | ||
| if (!Og::getMembership($entity, $entity->getOwner())) { |
There was a problem hiding this comment.
I think here you will get only the active memberships.
There was a problem hiding this comment.
Indeed!! I have also been trapped by this in the past, which is why I created #292 to lobby for changing this to return all memberships by default. I think it is not intuitive that this method returns filtered results by default, and an additional parameter should be passed to get the actual membership.
og.module
Outdated
| @@ -47,8 +47,11 @@ function og_entity_insert(EntityInterface $entity) { | |||
| return; | |||
| } | |||
|
|
|||
| $membership = Og::createMembership($entity, $entity->getOwner()); | |||
| $membership->save(); | |||
| // Other modules might interfere and create a membership. | |||
There was a problem hiding this comment.
maybe // Implementing modules might have created a membership ahead of us.
|
I think it's OK for me to merge this since I did not write the original patch but just the test coverage that proves the bug is real. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From issue #295