This repository has been archived by the owner on Aug 18, 2024. It is now read-only.
Show uid in LogicException for existing membership #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using OG with migrations, the module can generate a series of import failures with exceptions that could be more useful.
[error] LogicException: An OG membership already exists for group of entity-type node and ID: 8553 in Drupal\og\Entity\OgMembership->preSave() (line 466 of /var/www/localhost/drupal/web/modules/contrib/og/src/Entity/OgMembership.php).
[error] An OG membership already exists for group of entity-type node and ID: 8553 (/var/www/localhost/drupal/web/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php:783)
[error] LogicException: An OG membership already exists for group of entity-type node and ID: 11100 in Drupal\og\Entity\OgMembership->preSave() (line 466 of /var/www/localhost/drupal/web/modules/contrib/og/src/Entity/OgMembership.php).
[error] An OG membership already exists for group of entity-type node and ID: 11100 (/var/www/localhost/drupal/web/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php:783)
[error] LogicException: An OG membership already exists for group of entity-type node and ID: 11113 in Drupal\og\Entity\OgMembership->preSave() (line 466 of /var/www/localhost/drupal/web/modules/contrib/og/src/Entity/OgMembership.php).
[error] An OG membership already exists for group of entity-type node and ID: 11113 (/var/www/localhost/drupal/web/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php:783)
Including the uid in these exceptions will make the reported error more actionable; that information probably would be implicit when the exception is surfaced through a subscribe UI but is not apparent when migrating thousands of user memberships.
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using OG with migrations, the module can generate a series of import failures with exceptions that could be more useful.
Including the uid in these exceptions will make the reported error more actionable; that information probably would be implicit when the exception is surfaced through a subscribe UI but is not apparent when migrating thousands of user memberships.