This repository has been archived by the owner on Aug 18, 2024. It is now read-only.
Provide a method to retrieve the membership IDs of a given group #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ered by role name. This is equivalent to getGroupMembershipIdsByRoleNames() but avoids to load the full entity objects.
MPParsley
approved these changes
Apr 23, 2019
Co-Authored-By: pfrenssen <pieter@frenssen.be>
MPParsley
approved these changes
Apr 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For many of the methods in
MembershipManagerthat return entity data we offer two versions for convenience: one that returns IDs, and one that returns fully loaded entities. See for example:::getUserGroups()vs::getUserGroupIds()::getGroups()vs::getGroupIds()This PR adds a new method
::getGroupMembershipIdsByRoleNames()which is equivalent to::getGroupMembershipsByRoleNames()but avoids to load the full entity objects.I am needing this since I am implementing a block that shows the membership count of a group for #472 but it would be wasteful to load the full
OgMembershipentities just to get a count.