Skip to content
This repository has been archived by the owner on Aug 18, 2024. It is now read-only.

Add a cache tag to invalidate a group's user membership listings #483

Merged
merged 7 commits into from
Apr 30, 2019
Merged

Add a cache tag to invalidate a group's user membership listings #483

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b22c547
Provide a cache tag to invalidate a group's membership listings.
pfrenssen Apr 29, 2019
daf8ad5
Update documentation.
pfrenssen Apr 29, 2019
f275ab0
Do not assume the group is always available.
pfrenssen Apr 29, 2019
5d0995c
Use a constant for the group membership list cache tag prefix.
pfrenssen Apr 30, 2019
fbcf767
Do not assign variables inside if statements.
pfrenssen Apr 30, 2019
16f5145
Pass the membership states used in the count to the theme layer.
pfrenssen Apr 30, 2019
f2d4a1b
The attributes are put on the containing block div.
pfrenssen Apr 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/Entity/OgMembership.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,8 +494,10 @@ protected function invalidateTagsOnSave($update) {
// membership listings because it now meets those listings' filtering
// requirements. A newly created membership may start to appear in listings
// because it did not exist before.
$tags = Cache::buildTags('og-group-membership-list', $this->getGroup()->getCacheTagsToInvalidate());
Cache::invalidateTags($tags);
if ($group = $this->getGroup()) {
$tags = Cache::buildTags('og-group-membership-list', $group->getCacheTagsToInvalidate());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use a constant instead of 'og-group-membership-list'?

Cache::invalidateTags($tags);
}
}

/**
Expand All @@ -509,7 +511,9 @@ protected static function invalidateTagsOnDelete(EntityTypeInterface $entity_typ
// will be recalculated.
$tags = [];
foreach ($entities as $entity) {
$tags = Cache::mergeTags(Cache::buildTags('og-group-membership-list', $entity->getGroup()->getCacheTagsToInvalidate()), $tags);
if ($group = $entity->getGroup()) {
$tags = Cache::mergeTags(Cache::buildTags('og-group-membership-list', $group->getCacheTagsToInvalidate()), $tags);
}
}
Cache::invalidateTags($tags);
}
Expand Down