This repository has been archived by the owner on Aug 18, 2024. It is now read-only.
Test that an exception is thrown when a membership is saved using invalid roles #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is failing because of #502. |
|
It is green now on Travis. Codeclimate is still experimental. |
MPParsley
approved these changes
May 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is preparatory work for #487. In that issue it is proposed to refactor
OgMembership::getRolesIds()but we only have basic test coverage for the relation of roles and memberships. Our current test coverage (OgMembershipRoleReferenceTest) hits all of the related methods at least once, but we are lacking systematic coverage with data providers that check all possible code paths. I would like to enhance our code coverage before attempting to refactor the current code.This is a first PR in this effort, checking all the code paths in which saving a membership with invalid roles will result in an exception.