This repository has been archived by the owner on Aug 18, 2024. It is now read-only.
Do not require to pass full OgRole objects when we only need the ID. #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfrenssen
added
Clean-up
Performance
|
I'm merging this in so it can be included in the alpha3 release. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I stumbled upon this when looking into #487.
We have recently added the methods
MembershipManager::getUserGroupsByRoles()andMembershipManager::getUserGroupIdsByRoles()but in fact we do not need to have the full role objects for this to work. The first thing that is done is to retrieve the role ID and then the role objects are no longer required.We can simplify things by just requiring developers to pass in the role IDs. This would also save developers the effort of having to load the full
OgRoleobjects just to pass them into this method.