Do not needlessly load OgRole objects when only the role name is requ… …

…ired.

pfrenssen committed Jul 24, 2019

Speed up working with membership entities by avoiding the expensive g… …

…et() calls.

pfrenssen committed Jul 24, 2019

Field values for single property fields can be stored in arrays. …

When a field value is populated on an entity from the database the property
value is stored as a flat scalar value, while if the value is set through
the field API the value is an array.

See SqlContentEntityStorage::mapFromStorageRecords() vs
FieldItemList::setValue().

pfrenssen committed Jul 24, 2019

When field values are set on a freshly created, unsaved, entity the v… …

…alue array will be empty but the field item list will be populated.

pfrenssen committed Jul 24, 2019

Field item lists take priority over raw values, so ensure to use them… …

… if they are populated.

pfrenssen committed Jul 24, 2019

Use isset() rather than empty() to avoid undefined index errors.

pfrenssen committed Jul 24, 2019

Fall back to an empty value if the values array is not populated.

pfrenssen committed Jul 25, 2019

Adhere to coding standards.

pfrenssen committed Jul 25, 2019

Put the logic to retrieve field values in a reusable protected method.

pfrenssen committed Jul 25, 2019

Use the method for fast retrieval of field values from the pending co… …

…re issue.

See https://www.drupal.org/project/drupal/issues/2580551

pfrenssen committed Jul 26, 2019

Use a native PHP function to collect the role IDs.

pfrenssen committed Jul 26, 2019

Adhere to coding standards.

pfrenssen committed Jul 26, 2019

Merge remote-tracking branch 'github/8.x-1.x' into do-not-load-role-o… …

…bjects

pfrenssen committed Aug 8, 2019