Skip to content
This repository has been archived by the owner on Aug 18, 2024. It is now read-only.

Speed up retrieval of membership data by using a SELECT query #559

Merged
merged 11 commits into from
Aug 9, 2019
Merged

Speed up retrieval of membership data by using a SELECT query #559

merged 11 commits into from
Aug 9, 2019

Commits on Jul 26, 2019

  1. Speed up the retrieval of membership data on SQL databases.

    @pfrenssen
    pfrenssen committed Jul 26, 2019
    Configuration menu
    Copy the full SHA
    b7a36dc View commit details
    Browse the repository at this point in the history

  2. Add a test for the role contexts calculated based on results from a S… 

    …ELECT query.
    @pfrenssen
    pfrenssen committed Jul 26, 2019
    Configuration menu
    Copy the full SHA
    bcf7733 View commit details
    Browse the repository at this point in the history

  3. Adhere to coding standards.

    @pfrenssen
    pfrenssen committed Jul 26, 2019
    Configuration menu
    Copy the full SHA
    c8cb0da View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2019

  1. For normal authenticated users the roles field is empty.

    @pfrenssen
    pfrenssen committed Jul 27, 2019
    Configuration menu
    Copy the full SHA
    956fca3 View commit details
    Browse the repository at this point in the history

  2. Update tests.

    @pfrenssen
    pfrenssen committed Jul 27, 2019
    Configuration menu
    Copy the full SHA
    7a9fa1f View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2019

  1. Only consider active memberships for the role cache context. 

    This ensures that the SQL-based calculation of the cache context gives the
same results as the membership based one.
    @pfrenssen
    pfrenssen committed Jul 28, 2019
    Configuration menu
    Copy the full SHA
    e70ad55 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2019

  1. Merge remote-tracking branch 'github/do-not-load-role-objects' into q… 

    …uery-membership-data
    @pfrenssen
    pfrenssen committed Aug 8, 2019
    Configuration menu
    Copy the full SHA
    4c1b04f View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'github/8.x-1.x' into query-membership-data

    @pfrenssen
    pfrenssen committed Aug 8, 2019
    Configuration menu
    Copy the full SHA
    3719693 View commit details
    Browse the repository at this point in the history

  3. Test the SQL based implementation using a kernel test. 

    By executing the query against a real database instance rather than using a
mocked result we can better assert that the functionality is actually working as
expected.
    @pfrenssen
    pfrenssen committed Aug 8, 2019
    Configuration menu
    Copy the full SHA
    ba7e9a5 View commit details
    Browse the repository at this point in the history

  4. Adhere to coding standards.

    @pfrenssen
    pfrenssen committed Aug 8, 2019
    Configuration menu
    Copy the full SHA
    385d4cb View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-Authored-By: Maarten Segers <MPParsley@users.noreply.github.com>
    @pfrenssen @MPParsley
    pfrenssen and MPParsley authored Aug 8, 2019
    Configuration menu
    Copy the full SHA
    bbcfbf3 View commit details
    Browse the repository at this point in the history