This repository has been archived by the owner on Aug 18, 2024. It is now read-only.
The 'handler_settings' plugin config is deprecated #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfrenssen
suggested changes
Dec 8, 2019
Comment on lines
42
to
43
| // Provide at least one assertion. | ||
| $this->assertTrue(TRUE); |
There was a problem hiding this comment.
Let's explain here why this is done, people might not be familiar with the way PHPUnit marks tests without asserts as being risky.
Comment on lines
39
to
42
| // Remove also de backwards compatibility layer because that will be passed | ||
| // to the chosen selection handler setter and, as an effect, will trigger a | ||
| // deprecation notice. | ||
| // @see \Drupal\Core\Entity\EntityReferenceSelection\SelectionPluginBase::resolveBackwardCompatibilityConfiguration() |
pfrenssen
approved these changes
Dec 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #519