Skip to content
This repository has been archived by the owner on Aug 18, 2024. It is now read-only.

Use custom phpcs configuration #629

Merged
merged 1 commit into from
Feb 13, 2020
Merged

Conversation

MPParsley
Copy link
Collaborator

@MPParsley MPParsley commented Feb 13, 2020

Use the same phpcs configuration for tests as for codeclimate

From the discussion on #505 (comment)

The suggestions given are very good now, there are no more false positives.

Is there a way that we can source the PHP_CodeSniffer configuration from our own ruleset that we declare in phpcs-ruleset.xml.dist? There should not be any disparity between these, and if we can source this file then we can rest assured that if we make any changes to our coding standards then these will be picked up by codeclimate too.

For me personally this has not much added value since I tend to run my coding standards check before I commit and when I do have any coding standards violations I fix it by rebasing and force pushing rather than committing them one by one in the GitHub UI. But if you like it feel free to add it! For me the most important thing is that it does not cause any additional work for us as maintainers

@MPParsley MPParsley self-assigned this Feb 13, 2020
@MPParsley MPParsley requested a review from pfrenssen February 13, 2020 10:28
@pfrenssen
Copy link
Contributor

Great idea to consolidate the coding standards checks on both QA platforms!

This is good to go for me when tests come back green. There was one failure due to a timeout when downloading a dependency, but I have restarted this test so it will hopefully turn green now.

@MPParsley MPParsley merged commit 8b21bae into 8.x-1.x Feb 13, 2020
@MPParsley MPParsley deleted the feature/codeclimate_phpcs branch February 13, 2020 15:14
@pfrenssen pfrenssen added this to the 8.x-1.0-alpha5 milestone Aug 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants