#3129354 Add Drupal 9 support

[MPParsley]

https://www.drupal.org/project/og/issues/3129354 patch by @heddn.

[MPParsley]

@pfrenssen, did you plan another alpha release for Drupal 9?

[pfrenssen]

Thanks for working on this! I see that the Drupal 9 builds on Travis are failing due to a composer conflict with Drupal Console.

It would be great if we can get the Drupal 9 build green in this PR. I had a look but there is no Drupal 9 compatible branch of Drupal Console yet.

Still let's move forward with this. I would propose to skip the installation of Drupal Console for Drupal 9 builds and mark the DrupalConsoleAddFieldTest as skipped. When Drupal Console becomes compatible we can re-enable this test.

[pfrenssen]

Let's get the Drupal 9 builds green and remove them from the allowed_failures section in .travis.yml.

[amitaibu]

Travis are failing due to a composer conflict with Drupal Console.

IMO we can remove integration with Drupal Console, thus remove Drupal Console completely.

[MPParsley]

Let's get the Drupal 9 builds green and remove them from the allowed_failures section in .travis.yml.

Removed Drupal 9 from allowed_failures

[MPParsley]

Travis are failing due to a composer conflict with Drupal Console.

IMO we can remove integration with Drupal Console, thus remove Drupal Console completely.

Removed Drupal console from travis

[MPParsley]

@amitaibu
Seems like there was another reason to use Drupal console, or did you suggest to remove the support (OgAddFieldCommand) all together?:

1) Drupal\Tests\og\Kernel\Console\DrupalConsoleAddFieldTest::testNewGroup
Error: Class 'Drupal\Console\Core\Style\DrupalStyle' not found
/home/travis/build/Gizra/og/src/Command/OgAddFieldCommand.php:80
/home/travis/build/Gizra/drupal/vendor/symfony/console/Command/Command.php:240
/home/travis/build/Gizra/drupal/vendor/symfony/console/Tester/CommandTester.php:78
/home/travis/build/Gizra/og/tests/src/Kernel/Console/DrupalConsoleAddFieldTest.php:75
ERRORS!
Tests: 562, Assertions: 4971, Errors: 1.
 > Executing tests from /home/travis/build/Gizra/drupal/modules/og/og_ui/tests
PHPUnit 6.5.14 by Sebastian Bergmann and contributors.
Testing /home/travis/build/Gizra/drupal/modules/og/og_ui/tests

[amitaibu]

did you suggest to remove the support (OgAddFieldCommand) all together?

Indeed - can be removed. It's a very old attempt in adding Drupal Console commands, and I hardly think it's needed.

[MPParsley]

did you suggest to remove the support (OgAddFieldCommand) all together?

Indeed - can be removed. It's a very old attempt in adding Drupal Console commands, and I hardly think it's needed.

Rmeoved OgAddFieldCommand & DrupalConsoleAddFieldTest. Let's see what Travis says.

[MPParsley]

PHP Fatal error: Declaration of Drupal\Tests\Listeners\DrupalListener::endTest(PHPUnit\Framework\Test $test, float $time): void must be compatible with PHPUnit\Framework\TestListener::endTest(PHPUnit\Framework\Test $test, $time) in /home/travis/build/Gizra/drupal/core/tests/Drupal/Tests/Listeners/DrupalListener.php on line 14

[heddn]

I think the failures are due to PHPUnit version miss-matching.

[pfrenssen]

The D9 branch is green! 👍

[pfrenssen]

I see what is wrong, I will try to fix it. We should remove the old workaround for PHP 5.6,

[pfrenssen]

Starting to see green results. I have also enabled the Composer cache, this saves ~30 seconds on downloading dependencies. I included Drupal 9.1 in the build matrix because this is also already in development.

Out of scope for this PR but I am seeing that on Drupal 8.8+ the only test that is failing is OgComplexWidgetTest::testFields(). This is great news, once that widget is removed we can also guarantee that OG works correctly on PHP 7.4.

[MPParsley]

And it's in! Thanks all!

[MPParsley]

@pfrenssen can you push it to d.o so we can close https://www.drupal.org/node/3129354 (only mobile access atm)?

[pfrenssen]

OK!