Skip to content
This repository has been archived by the owner on Aug 18, 2024. It is now read-only.

Remove dead code in OgAccessHookTest #648

Merged
merged 2 commits into from
Jul 3, 2020
Merged

Remove dead code in OgAccessHookTest #648

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a31b87
Remove obsolete test code.
pfrenssen Jul 2, 2020
ee6f892
Merge remote-tracking branch 'origin/8.x-1.x' into remove-dead-code
pfrenssen Jul 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions tests/src/Unit/OgAccessHookTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,17 +44,7 @@ public function testNotContentEntity($operation) {
public function testGetEntityGroups($operation) {
$this->user->hasPermission(OgAccess::ADMINISTER_GROUP_PERMISSION)->willReturn(TRUE);
$user_entity_access = og_entity_access($this->groupContentEntity->reveal(), $operation, $this->user->reveal());

// @todo This is strange, 'view' is not part of the operations supplied by
// ::permissionsProvider(). And why would a group administrator be allowed
// access to all operations, except 'view'? Shouldn't this also return
// 'allowed'?
if ($operation == 'view') {
$this->assertTrue($user_entity_access->isNeutral());
}
else {
$this->assertTrue($user_entity_access->isAllowed());
}
$this->assertTrue($user_entity_access->isAllowed());
}

}