Skip to content
This repository has been archived by the owner on Aug 18, 2024. It is now read-only.

Document how OG handles access and permissions #693

Merged
merged 12 commits into from
Apr 22, 2021

Conversation

pfrenssen
Copy link
Contributor

Fixes #510.

@pfrenssen pfrenssen marked this pull request as ready for review August 13, 2020 08:54
docs/access.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@MPParsley MPParsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great writeup thanks!

Sometimes we write OG sometimes Organic Groups, I'd try to be consistent and use Organic Group everywhere but I'll let you decide.

We should probably also reference this document from the README.md

docs/access.md Outdated Show resolved Hide resolved
docs/access.md Outdated Show resolved Hide resolved
docs/access.md Outdated Show resolved Hide resolved
docs/access.md Outdated Show resolved Hide resolved
docs/access.md Show resolved Hide resolved
docs/access.md Outdated Show resolved Hide resolved
docs/access.md Outdated Show resolved Hide resolved
docs/access.md Outdated Show resolved Hide resolved
docs/access.md Show resolved Hide resolved
docs/access.md Show resolved Hide resolved
@amitaibu
Copy link
Member

Sometimes we write OG sometimes Organic Groups

I usually write the first occurrence in the doc as "Organic Groups (OG), ...", and then continue with OG

@pfrenssen
Copy link
Contributor Author

Adding to the milestone since this is closely related to the work done to OG Access in the upcoming release, it would be good to also include this documentation along with the changes.

@pfrenssen
Copy link
Contributor Author

This has already been approved, but changes were made afterwards. @amitaibu or @MPParsley do these changes look OK?

Copy link
Member

@amitaibu amitaibu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks great, thanks!

Copy link
Collaborator

@MPParsley MPParsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this. The phpcs issues are not related to this PR.

@MPParsley MPParsley merged commit bb5a4b2 into 8.x-1.x Apr 22, 2021
@MPParsley MPParsley deleted the document-access-system branch April 22, 2021 09:28
@MPParsley
Copy link
Collaborator

Error in Travis will be fixed in #720.

1) Drupal\Tests\og\Functional\GroupSubscribeTest::testSubscribeAccess
Behat\Mink\Exception\ExpectationException: Current response status code is 404, but 500 expected.

@pfrenssen
Copy link
Contributor Author

Thanks! Good job preparing the release, unfortunately I don't have the availability to assist at the moment.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation for OG permission layer
3 participants