Skip to content
This repository has been archived by the owner on Aug 18, 2024. It is now read-only.

Use instances of interface for variable definitions. #702

Merged
merged 3 commits into from
Jan 19, 2021

Conversation

idimopoulos
Copy link
Contributor

In PHPStorm, there is a complaint about the $og_roles being an instance of OgRole and not of OgRoleInterface. Fixing very minor documentation entries.

$membership
      ->setOwner($user)
      ->setGroup($collection)
      ->setState($state)
      ->setRoles($og_roles)
      ->save();

@pfrenssen
Copy link
Contributor

Thanks! But it seems this is blocked by some new coding standards violations that are being detected by a new version of phpcs / coder.

This is blocked on #700

@pfrenssen pfrenssen added this to the 8.x-1.0-alpha6 milestone Oct 7, 2020
@pfrenssen
Copy link
Contributor

Approving and this can be merged without having a passing test suite, since this is a documentation fix which does not affect tests.

@amitaibu amitaibu merged commit a77a89b into Gizra:8.x-1.x Jan 19, 2021
@amitaibu amitaibu deleted the minor_fix branch January 19, 2021 09:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants