This repository has been archived by the owner on Aug 18, 2024. It is now read-only.
Revert the fix from #709 #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems the test for PR #709 still passes if the fix is reverted. It might not be needed to special case this route after all?
|
OK I found out why this is passing on my installation. This is actually a duplicate of a core bug: Issue #2730631: Upcast node and node_revision parameters of node revision routes. I had this patch applied. In the meantime this has been fixed in core and released in Drupal 9.3. Shall we remove the fix from OG since this is not the right place to fix it? If users are affected they can update to Drupal 9.3, or on older versions they can apply the patch from the core issue. |
Yes, sounds right |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In local testing I have discovered that the fix that was proposed in #709 does not seem to be needed. The test for that PR still passes if the fix is reverted.
It might be possible I am getting a false negative due to some environment specific issues (for example, I have only tested on a Drupal 8 installation). Also it is possible that the test for the issue was not capturing the exact steps needed to replicate the bug.
Let's see what the test bot says.